Code review comment for lp:~acsone-openerp/banking-addons/ba-70-payment-export-refactoring

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Stéphane,

once again thank you for your patience. I have succesfully tested migrating existing databases to the current state of the branch. Meanwhile, I am writing a lengthy test that simulates a payment order - bank statement round trip, but that should not keep back the merge of this branch.

In the last revisions, a slight error showed up: BaseModel._auto_init() actually returns something that can be meaningful. It does not seem to make a difference here but I think it would be best to return the result of super() after line 1226.

And then we're done.

review: Needs Fixing

« Back to merge proposal