Merge lp:~acsone-openerp/banking-addons/ba-70-missing-transfer-account into lp:banking-addons

[Stéphane Bidoul (Acsone)]

Transfer account and transfer journal are optional in payment modes. This patch attempts to handle such situations.

[Stefan Rijnhart (Opener) (stefan-opener)]

Thank you for noticing this. We need to be able to handle this situation, but the question rises: how are your payment orders going to go into state 'done' when you don't use the reconciliation bit of the workflow? Apart from the technical details, it would be interesting to hear about how you actually reconcile the invoices with the amount of the payment order when it appears on the bank statement.

[Stéphane Bidoul (Acsone) (sbi)]

If there is no transit account, the payment will stay in state "sent" forever, I suppose. Which is similar to the default payment order workflow in OpenERP where the sent state does not exist.

Which makes me think... even without a transit account, one could imagine having the payment workflow (in sent state) listen on a trigger from account.move.line with a test_paid() condition, just like the invoice does to detect it has been paid?

[Stefan Rijnhart (Opener) (stefan-opener)]

Yes, I was wondering about that. That could be the key to integrating c2c's statement modules with account_banking_payment.

So you do the reconciliation manually? Do you get the invoices from the payment order each on their own bank statement line with the correct partner?

[Stéphane Bidoul (Acsone) (sbi)]

We receive one bank statement line for each payment line from the bank. With SEPA credit transfers in particular, one can choose to have it that way or receive a single statement line per payment order.

The partner can be found quite reliably for each bank statement line since we get the counterparty bank account for each statement line.

Then reconciliation is mostly automatic.

[Holger Brunn (Therp) (hbrunn)]

Just one nitpick:
#157 remove this one instead of commenting it

review: Approve

[lp:~acsone-openerp/banking-addons/ba-70-missing-transfer-account]

180. By Stéphane Bidoul (Acsone) on 2013-10-14

[MRG] sync with 7.0 head

[Stéphane Bidoul (Acsone) (sbi)]

This one was out of sync with 7.0 head. I merged so the diff is now clean again.

=== modified file 'account_banking_payment/model/account_payment.py'
--- account_banking_payment/model/account_payment.py	2013-10-02 09:02:54 +0000
+++ account_banking_payment/model/account_payment.py	2013-10-14 11:19:01 +0000
@@ -241,6 +241,8 @@
             'debit': _('Direct debit order'),
             }
         for order in self.browse(cr, uid, ids, context=context):
+            if not order.mode.transfer_journal_id or not order.mode.transfer_account_id:
+                continue
             for line in order.line_ids:
                 # basic checks
                 if not line.move_line_id: