Merge lp:~acsone-openerp/banking-addons/account_statement_base_completion_import_order_fix into lp:banking-addons/bank-statement-reconcile-70

Proposed by Stéphane Bidoul (Acsone)
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 114
Merged at revision: 120
Proposed branch: lp:~acsone-openerp/banking-addons/account_statement_base_completion_import_order_fix
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 11 lines (+2/-2)
1 file modified
account_statement_base_completion/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~acsone-openerp/banking-addons/account_statement_base_completion_import_order_fix
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Laurent Mignon (Acsone) (community) code review, tested Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+202220@code.launchpad.net

Description of the change

Fix import order in account_statement_base_completion.

This is necessary to avoid module intialization errors when _default_profile is called during _auto_init which in turns tries to query res_partner.bank_statement_label which is not initalized yet, and the bank_statement_label column may not be created.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

Problem reproduced without the proposal and fixed after applying the proposal

review: Approve (code review, tested)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Already merged

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Merged at revno 120

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_base_completion/__init__.py'
2--- account_statement_base_completion/__init__.py 2012-12-20 13:37:01 +0000
3+++ account_statement_base_completion/__init__.py 2014-01-19 17:14:52 +0000
4@@ -19,5 +19,5 @@
5 #
6 ##############################################################################
7
8-import statement
9-import partner
10+from . import partner
11+from . import statement

Subscribers

People subscribed via source and target branches