Merge lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install into lp:banking-addons/bank-statement-reconcile-70

Proposed by Stéphane Bidoul (Acsone)
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 115
Merged at revision: 130
Proposed branch: lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 46 lines (+9/-10)
2 files modified
account_statement_bankaccount_completion/__openerp__.py (+8/-9)
account_statement_bankaccount_completion/data.xml (+1/-1)
To merge this branch: bzr merge lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Laurent Mignon (Acsone) (community) code review Approve
Review via email: mp+202221@code.launchpad.net

Description of the change

Do not auto_install account_statement_bankaccount_completion.

Plus a bit of pep8 and cleanup.

To post a comment you must log in.
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_bankaccount_completion/__openerp__.py'
2--- account_statement_bankaccount_completion/__openerp__.py 2013-09-12 09:05:01 +0000
3+++ account_statement_bankaccount_completion/__openerp__.py 2014-01-19 17:40:45 +0000
4@@ -29,21 +29,20 @@
5 'account_statement_base_completion',
6 ],
7 'description': """
8- Add a completion method based on the partner bank account number provided by the bank/office.
9+ Add a completion method based on the partner bank account number
10+ provided by the bank/office.
11
12- Completion will look in the partner with that bank account number to match the partner,
13- then it will fill in the bank statement line with it to ease the reconciliation.
14+ Completion will look in the partner with that bank account number
15+ to match the partner, then it will fill in the bank statement line
16+ with it to ease the reconciliation.
17
18 """,
19 'website': 'http://www.acsone.eu',
20- 'init_xml': [],
21- 'update_xml': [
22+ 'data': [
23 "data.xml",
24 ],
25- 'demo_xml': [],
26- 'test': [],
27+ 'demo': [],
28 'installable': True,
29- 'images': [],
30- 'auto_install': True,
31+ 'auto_install': False,
32 'license': 'AGPL-3',
33 }
34
35=== modified file 'account_statement_bankaccount_completion/data.xml'
36--- account_statement_bankaccount_completion/data.xml 2013-08-26 12:19:09 +0000
37+++ account_statement_bankaccount_completion/data.xml 2014-01-19 17:40:45 +0000
38@@ -3,7 +3,7 @@
39 <data noupdate="1">
40
41 <record id="bank_statement_completion_rule_10" model="account.statement.completion.rule">
42- <field name="name">Match from bank account number (Nomal or IBAN))</field>
43+ <field name="name">Match from bank account number (Normal or IBAN))</field>
44 <field name="sequence">10</field>
45 <field name="function_to_call">get_from_bank_account</field>
46 </record>

Subscribers

People subscribed via source and target branches