Merge lp:~acsone-openerp/account-financial-tools/account_chart_update_tac_code_code into lp:~account-core-editors/account-financial-tools/7.0

[Stéphane Bidoul (Acsone)]

Hi,

Here is a small improvement to account_chart_update.

When a tax_code cannot be matched by name, attempt to match by code if one exists.

Thanks for this excellent tool.

Best regards,

-sbi

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Stéphane,

For me your contribution is ok ,thanks you. just a point, I think you include in your commit (probably by mistake) a change in the "account_credit_control/security/ir.model.access.csv" file.

Can you remove it please ?

review: Needs Fixing (code review, no tests)

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stéphane, thank you very much for the improvement. Apart from the problem said by Joël, I think you can improve the code putting this:

if not tax_code_ids:
    # if we could not match no tax code template name,
    # try to match on tax code template code, if any
    tax_code_code = tax_code_template.code
    if tax_code_code:
        tax_code_ids = tax_codes.search(cr, uid, [
              ('code', '=', tax_code_code),
              ('company_id', '=', wizard.company_id.id)
              ])
if tax_code_ids:
    tax_code_template_mapping[
        tax_code_template.id] = tax_code_ids[0]

Regards.

review: Needs Fixing (code review, no test)

Unmerged revisions

126. By Stéphane Bidoul (Acsone) on 2013-11-18

[IMP] attempt to match tax code on code if no match on name was found

125. By Stéphane Bidoul (Acsone) on 2013-11-07

[FIX] fix bug in account_credit_control preventing portal user to view their invoices

=== modified file 'account_chart_update/wizard/wizard_chart_update.py'
--- account_chart_update/wizard/wizard_chart_update.py	2013-10-18 16:44:19 +0000
+++ account_chart_update/wizard/wizard_chart_update.py	2013-11-18 16:22:00 +0000
@@ -270,6 +270,18 @@
             if tax_code_ids:
                 tax_code_template_mapping[
                     tax_code_template.id] = tax_code_ids[0]
+            else:
+                # if we could not match no tax code template name, 
+                # try to match on tax code template code, if any 
+                tax_code_code = tax_code_template.code
+                if tax_code_code:
+                    tax_code_ids = tax_codes.search(cr, uid, [
+                        ('code', '=', tax_code_code),
+                        ('company_id', '=', wizard.company_id.id)
+                    ])
+                    if tax_code_ids:
+                        tax_code_template_mapping[
+                            tax_code_template.id] = tax_code_ids[0]
 
     def _map_account_template(self, cr, uid, wizard, account_template_mapping, account_template, context=None):
         """