Merge lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi2 into lp:~account-report-core-editor/account-financial-report/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi2 |
Merge into: | lp:~account-report-core-editor/account-financial-report/7.0 |
Diff against target: |
41 lines (+33/-0) 1 file modified
account_financial_report_webkit/tests/general_ledger.yml (+33/-0) |
To merge this branch: | bzr merge lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | Resubmit on 2014-08-06 | ||
Laurent Mignon (Acsone) (community) | code | Approve on 2014-07-11 | |
Leonardo Pistone | 2014-07-04 | Approve on 2014-07-07 | |
Review via email:
|
Laurent Mignon (Acsone) (lmi) wrote : | # |
LGTM with the same remark as Leonardo
lmi
- 95. By Stéphane Bidoul (Acsone) on 2014-07-11
-
[IMP] account_
financial_ report_ webkit test: test for presence of opening period The opening period is part of the demo data in 7.0 OCB and 8.0 offical and
the workaround is necessary only for 7.0 official.
Stéphane Bidoul (Acsone) (sbi) wrote : | # |
I factored out cur_year and made the workaround compatible with OCB 7.0.
Pedro Manuel Baeza (pedro.baeza) wrote : | # |
This project is now hosted on https:/
Unmerged revisions
- 95. By Stéphane Bidoul (Acsone) on 2014-07-11
-
[IMP] account_
financial_ report_ webkit test: test for presence of opening period The opening period is part of the demo data in 7.0 OCB and 8.0 offical and
the workaround is necessary only for 7.0 official. - 94. By Stéphane Bidoul (Acsone) on 2014-07-04
-
[FIX] workaround to 7.0 demo data weirdness in account_
financial_ report_ webkit test suite Do not forward port to 8.0, as this has been fixed in odoo master.
Stéphane,
Maybe you could refactor a bit with:
cur_year = time.strftime('%Y')
and then use it later?
being that a small change, I approve anyway