Merge lp:~acl-openerp/openobject-server/6.1-opw-576860-acl into lp:openobject-server/6.1

Proposed by Anaël Closson (openerp)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 4244
Proposed branch: lp:~acl-openerp/openobject-server/6.1-opw-576860-acl
Merge into: lp:openobject-server/6.1
Diff against target: 12 lines (+2/-0)
1 file modified
openerp/report/render/rml2pdf/trml2pdf.py (+2/-0)
To merge this branch: bzr merge lp:~acl-openerp/openobject-server/6.1-opw-576860-acl
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+115689@code.launchpad.net

Description of the change

Rapports written using rml now allows blank lines in user text.

Steps to reproduce the bug:
* install the module account_followup
* enter text with spaces between lines
* print the followup => blank lines are not printed

This change should impact every modules using trml2pdf

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-server/trunk-opw-576860-port-kbh/+merge/138635 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Revision history for this message
Olivier Laurent (Acsone) (olivier-laurent) wrote :

Hello,

Until today, it seems this fix:
- is not yet merged within 6.1 nor 7.0 branches
- has no effect with the version 2.6 of the reportlab library.

What is the real status/future of this fix/MP ?

Thanks,
Olivier LAURENT

Unmerged revisions

4244. By Anaël Closson (openerp)

[FIX] double line breaks where not printed, cannot make spaces in a text without modifying the rml template

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/report/render/rml2pdf/trml2pdf.py'
2--- openerp/report/render/rml2pdf/trml2pdf.py 2012-07-16 07:52:17 +0000
3+++ openerp/report/render/rml2pdf/trml2pdf.py 2012-07-19 10:16:33 +0000
4@@ -743,6 +743,8 @@
5 style.__dict__.update(extra_style)
6 result = []
7 for i in self._textual(node).split('\n'):
8+ if len(i.strip()) == 0:
9+ i = '<font color="white"> </font>'
10 result.append(platypus.Paragraph(i, style, **(utils.attr_get(node, [], {'bulletText':'str'}))))
11 return result
12 elif node.tag=='barCode':