Merge ~ack/maas:fix-fabric-id-sequence-3.4.0 into maas:branch-3.4.0

[Alberto Donato]

LP:2037524 fix bigint migration for IDs, exclude Fabric since 0 value is used there too

backport of ba319aecf from master

[Alberto Donato (ack)]

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-fabric-id-sequence-3.4.0 lp:~ack/maas/+git/maas into -b branch-3.4.0 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/3660/console
COMMIT: aa972f9d501b03fed8ea866a8bdd4b1eb5241d24

review: Needs Fixing

[MAAS Lander (maas-lander)]

LANDING
-b fix-fabric-id-sequence-3.4.0 lp:~ack/maas/+git/maas into -b branch-3.4.0 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/3662/console

[MAAS Lander (maas-lander)]

LANDING
-b fix-fabric-id-sequence-3.4.0 lp:~ack/maas/+git/maas into -b branch-3.4.0 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/3663/console

diff --git a/src/maasserver/migrations/maasserver/0302_big_auto_field.py b/src/maasserver/migrations/maasserver/0302_big_auto_field.py
index 73ebf4f..6fb411e 100644
--- a/src/maasserver/migrations/maasserver/0302_big_auto_field.py
+++ b/src/maasserver/migrations/maasserver/0302_big_auto_field.py
@@ -164,11 +164,6 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.AlterField(
-            model_name="domain",
-            name="id",
-            field=models.AutoField(primary_key=True, serialize=False),
-        ),
-        migrations.AlterField(
             model_name="event",
             name="id",
             field=models.BigAutoField(
@@ -189,16 +184,6 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.AlterField(
-            model_name="fabric",
-            name="id",
-            field=models.BigAutoField(
-                auto_created=True,
-                primary_key=True,
-                serialize=False,
-                verbose_name="ID",
-            ),
-        ),
-        migrations.AlterField(
             model_name="filestorage",
             name="id",
             field=models.BigAutoField(
@@ -239,11 +224,6 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.AlterField(
-            model_name="globaldefault",
-            name="id",
-            field=models.AutoField(primary_key=True, serialize=False),
-        ),
-        migrations.AlterField(
             model_name="interface",
             name="id",
             field=models.BigAutoField(
@@ -564,11 +544,6 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.AlterField(
-            model_name="resourcepool",
-            name="id",
-            field=models.AutoField(primary_key=True, serialize=False),
-        ),
-        migrations.AlterField(
             model_name="rootkey",
             name="id",
             field=models.BigAutoField(
diff --git a/src/maasserver/models/domain.py b/src/maasserver/models/domain.py
index 5dccc9f..d1fa27d 100644
--- a/src/maasserver/models/domain.py
+++ b/src/maasserver/models/domain.py
@@ -180,9 +180,11 @@ class Domain(CleanSave, TimestampedModel):
 
     objects = DomainManager()
 
-    # explicitly define the AutoField since default is BigAutoField which
-    # doesn't allow 0 as a value (used for the default domain)
-    id = AutoField(primary_key=True)
+    # explicitly define the AutoField since default is BigAutoField and causing
+    # modifications causes django to include this in the migration and not
+    # allowing 0 as a value
+    id = AutoField(primary_key=True, auto_created=True, verbose_name="ID")
+
     name = DomainNameField(
         max_length=256,
         editable=True,
diff --git a/src/maasserver/models/fabric.py b/src/maasserver/models/fabric.py
index 209a9ad..76bc8e1 100644
--- a/src/maasserver/models/fabric.py
+++ b/src/maasserver/models/fabric.py
@@ -8,7 +8,7 @@ from operator import attrgetter
 import re
 
 from django.core.exceptions import PermissionDenied, ValidationError
-from django.db.models import CharField, Manager, TextField
+from django.db.models import AutoField, CharField, Manager, TextField
 from django.db.models.query import QuerySet
 
 from maasserver.fields import MODEL_NAME_VALIDATOR
@@ -133,6 +133,11 @@ class Fabric(CleanSave, TimestampedModel):
 
     objects = FabricManager()
 
+    # explicitly define the AutoField since default is BigAutoField and causing
+    # modifications causes django to include this in the migration and not
+    # allowing 0 as a value
+    id = AutoField(primary_key=True, auto_created=True, verbose_name="ID")
+
     # We don't actually allow blank or null name, but that is enforced in
     # clean() and save().
     name = CharField(
diff --git a/src/maasserver/models/globaldefault.py b/src/maasserver/models/globaldefault.py
index 8bf5991..5468504 100644
--- a/src/maasserver/models/globaldefault.py
+++ b/src/maasserver/models/globaldefault.py
@@ -37,9 +37,10 @@ class GlobalDefault(CleanSave, TimestampedModel):
 
     objects = GlobalDefaultManager()
 
-    # explicitly define the AutoField since default is BigAutoField which
-    # doesn't allow 0 as a value
-    id = AutoField(primary_key=True)
+    # explicitly define the AutoField since default is BigAutoField and causing
+    # modifications causes django to include this in the migration and not
+    # allowing 0 as a value
+    id = AutoField(primary_key=True, auto_created=True, verbose_name="ID")
 
     domain = ForeignKey(
         Domain, null=False, blank=False, editable=True, on_delete=PROTECT
diff --git a/src/maasserver/models/resourcepool.py b/src/maasserver/models/resourcepool.py
index fed6f34..f6012a1 100644
--- a/src/maasserver/models/resourcepool.py
+++ b/src/maasserver/models/resourcepool.py
@@ -108,9 +108,11 @@ class ResourcePool(CleanSave, TimestampedModel):
 
     objects = ResourcePoolManager()
 
-    # explicitly define the AutoField since default is BigAutoField which
-    # doesn't allow 0 as a value (used for the default resource pool)
-    id = AutoField(primary_key=True)
+    # explicitly define the AutoField since default is BigAutoField and causing
+    # modifications causes django to include this in the migration and not
+    # allowing 0 as a value
+    id = AutoField(primary_key=True, auto_created=True, verbose_name="ID")
+
     name = CharField(
         max_length=256,
         unique=True,