Merge ~ack/maas:1938321-post-refresh-hook-all-mode into maas:2.8

[Alberto Donato]

LP:1938321 - drop check for service status in hook

because of a snapd issue, the hook can't reliably know if the service is
disabled.
For this reason, always start the service so migrations can be performed

[MAAS Lander (maas-lander)]

UNIT TESTS
-b 1938321-post-refresh-hook-all-mode lp:~ack/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 065696fae68623c5d192708a04f57b75ee0a27e9

review: Approve

[Adam Collard (adam-collard)]

review: Approve

diff --git a/snap/hooks/install b/snap/hooks/install
index 910a2da..0f4dd2e 100755
--- a/snap/hooks/install
+++ b/snap/hooks/install
@@ -48,13 +48,7 @@ maas_snap_mode() {
 if [ "$(maas_snap_mode)" = "all" ]; then
     # When running in all mode and not disabled, start services to ensure
     # PostgreSQL is running to perform migrations
-    service="${SNAP_INSTANCE_NAME}.supervisor"
-    if snapctl services "$service"  | grep -q disabled; then
-        echo "Can't refresh snap in 'all' mode while disabled." >&2
-        exit 1
-    else
-        snapctl start "$service"
-    fi
+    snapctl start "${SNAP_INSTANCE_NAME}.supervisor"
 fi
 
 # Perform migrations. Does nothing in 'rack' or 'none' mode.