Merge ~ack/maas:certificate-test-fix-2.8 into maas:2.8

Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: dbf78640c180ee0685f62e200e630f62d968dad7
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ack/maas:certificate-test-fix-2.8
Merge into: maas:2.8
Diff against target: 36 lines (+9/-3)
1 file modified
src/provisioningserver/tests/test_maas_certificates.py (+9/-3)
Reviewer Review Type Date Requested Status
Dougal Matthews (community) Approve
Review via email: mp+385479@code.launchpad.net

Commit message

LP: #1882806 - Fix failing certificate test due to bad cache during testing.

To post a comment you must log in.
Revision history for this message
Dougal Matthews (d0ugal) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/provisioningserver/tests/test_maas_certificates.py b/src/provisioningserver/tests/test_maas_certificates.py
2index 9223a66..f429aab 100644
3--- a/src/provisioningserver/tests/test_maas_certificates.py
4+++ b/src/provisioningserver/tests/test_maas_certificates.py
5@@ -22,22 +22,28 @@ class TestMAASCertificates(MAASTestCase):
6 def setUp(self):
7 super().setUp()
8 self.certificates_dir = self.useFixture(TempDirectory()).path
9+ self.orig_maas_private_key = maas_certificates.MAAS_PRIVATE_KEY
10 maas_certificates.MAAS_PRIVATE_KEY = os.path.join(
11 self.certificates_dir, "maas.key"
12 )
13+ self.orig_maas_public_key = maas_certificates.MAAS_PUBLIC_KEY
14 maas_certificates.MAAS_PUBLIC_KEY = os.path.join(
15 self.certificates_dir, "maas.pub"
16 )
17+ self.orig_maas_certificate = maas_certificates.MAAS_CERTIFICATE
18 maas_certificates.MAAS_CERTIFICATE = os.path.join(
19 self.certificates_dir, "maas.crt"
20 )
21-
22- def tearDown(self):
23- super().tearDown()
24 maas_certificates._cert_not_before = None
25 maas_certificates._cert_not_after = None
26 maas_certificates._cert_mtime = None
27
28+ def tearDown(self):
29+ super().tearDown()
30+ maas_certificates.MAAS_PRIVATE_KEY = self.orig_maas_private_key
31+ maas_certificates.MAAS_PUBLIC_KEY = self.orig_maas_public_key
32+ maas_certificates.MAAS_CERTIFICATE = self.orig_maas_certificate
33+
34 def test_generate_rsa_if_needed(self):
35 self.assertTrue(maas_certificates.generate_rsa_keys_if_needed())
36 self.assertTrue(os.path.exists(maas_certificates.MAAS_PRIVATE_KEY))

Subscribers

People subscribed via source and target branches