Merge lp:~achiang/laika/status_fix into lp:laika

Proposed by Alex Chiang on 2010-11-07
Status: Merged
Merged at revision: 13
Proposed branch: lp:~achiang/laika/status_fix
Merge into: lp:laika
Diff against target: 49 lines (+15/-3)
1 file modified
laika (+15/-3)
To merge this branch: bzr merge lp:~achiang/laika/status_fix
Reviewer Review Type Date Requested Status
Paul Hummer (community) 2010-11-07 Approve on 2010-11-09
Review via email: mp+40266@code.launchpad.net

Commit message

Search launchpad for all statuses, not just the default statuses returned by searchTask().

This change gives us a more complete picture of our launchpad activity within the window.

Description of the change

Search launchpad for all statuses, not just the default statuses returned by searchTask().

This change gives us a more complete picture of our launchpad activity within the window.

To post a comment you must log in.
Paul Hummer (rockstar) wrote :

The status list has some funky indentation, but other than that, this looks fine to me. I wonder if you should file a bug that indicates that you shouldn't have to maintain this list yourself.

review: Approve
lp:~achiang/laika/status_fix updated on 2010-11-09
14. By Alex Chiang on 2010-11-09

Fix whitespace in status list.

Alex Chiang (achiang) wrote :

Thank you for the review.

I filed this:

https://bugs.launchpad.net/bugs/672883

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'laika'
2--- laika 2010-10-21 17:19:42 +0000
3+++ laika 2010-11-09 03:58:41 +0000
4@@ -44,6 +44,15 @@
5 self.user = self.launchpad.people[user]
6 self.window = window
7 self.ppas = ppas
8+ self.status = ["New",
9+ "Incomplete",
10+ "Invalid",
11+ "Won't Fix",
12+ "Confirmed",
13+ "Triaged",
14+ "In Progress",
15+ "Fix Committed",
16+ "Fix Released" ]
17
18 def print_header(self, header):
19 print "==", header, "=="
20@@ -85,7 +94,8 @@
21 statuses = ['closed', 'fix_released', 'fix_committed',
22 'in_progress', 'triaged', 'confirmed', 'created']
23
24- tasks = self.user.searchTasks(assignee=self.user)
25+ tasks = self.user.searchTasks(assignee=self.user,
26+ status=self.status)
27 self.print_header("Assigned Bugs")
28
29 for t in tasks:
30@@ -109,7 +119,8 @@
31 print
32
33 def print_comments(self):
34- tasks = self.user.searchTasks(bug_commenter=self.user)
35+ tasks = self.user.searchTasks(bug_commenter=self.user,
36+ status=self.status)
37 self.print_header("Commented Bugs")
38 for t in tasks:
39 if self.bugs.has_key(t.bug.id):
40@@ -124,7 +135,8 @@
41 print
42
43 def print_reported(self):
44- tasks = self.user.searchTasks(bug_reporter=self.user)
45+ tasks = self.user.searchTasks(bug_reporter=self.user,
46+ status=self.status)
47 self.print_header("Reported Bugs")
48 for t in tasks:
49 if self.bugs.has_key(t.bug.id):

Subscribers

People subscribed via source and target branches

to all changes: