Code review comment for lp:~achiang/laika/configparser

Revision history for this message
Alex Chiang (achiang) wrote :

Thanks for the review. I'll add the whitespace back.

I think the get_launchpad_username_from_bazaar thing was to cover the case where your unix login doesn't match your launchpad login. Instead of specifying it on the command line each time, it glommed onto something you would have set up for bazaar anyway.

But now that laika can read its own config file, we can just specify the launchpad user name there, the same way you would have done it on the command line, but permanently so you only have to set it once.

« Back to merge proposal