Merge lp:~achiang/hydrazine/hydrazine-fix-official-tags into lp:hydrazine

[Alex Chiang]

  bugclient: fix stacktrace in do_official_tags when there are no tags

  Slight refactor of logic to return early if there are no official tags
  defined for a pillar. Without this fix, we get the following stack trace:

  Traceback (most recent call last):
    File "./bugclient", line 519, in <module>
      main(sys.argv)
    File "./bugclient", line 515, in main
      cmd.cmdloop()
    File "/usr/lib/python2.7/cmd.py", line 142, in cmdloop
      stop = self.onecmd(line)
    File "./bugclient", line 379, in onecmd
      return cmd.Cmd.onecmd(self, cmdline)
    File "/usr/lib/python2.7/cmd.py", line 219, in onecmd
      return func(arg)
    File "./bugclient", line 233, in do_official_tags
      _show_columnated(tags)
    File "./bugclient", line 465, in _show_columnated
      longest = max(map(len, tags))
  ValueError: max() arg is an empty sequence

[Martin Pool (mbp)]

  vote approve

review: Approve

=== modified file 'bugclient'
--- bugclient	2011-10-12 03:14:13 +0000
+++ bugclient	2011-10-12 05:51:16 +0000
@@ -228,8 +228,11 @@
     def do_official_tags(self, ignored):
         """Show the official tags for the current pillar."""
         if self._needs_pillar(): return
+        tags = self.pillar.official_bug_tags
+        if not tags:
+            print 'No official bug tags for %s' % self.pillar.name
+            return
         print 'Official bug tags for %s' % self.pillar.name
-        tags = self.pillar.official_bug_tags
         _show_columnated(tags)
 
     def do_open(self, ignored):