Merge lp:~acerisara/ubuntu-calendar-app/year-view-autopilot into lp:ubuntu-calendar-app

[Andrea Cerisara]

Autopilot tests for yearly view.

Autopilot tests for yearly view.

https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1237529.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:145
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/141/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/961
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/141
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/141
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/141
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/141

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/141/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:146
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/142/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/968
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/142
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/142
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/142
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/142

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/142/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Andrea, this looks great. I like the swipe_view function, with optional xpad. Nicely done. Checking the label color works well enough, and you made it look for non-black which should work out fine for now. As we moved forward we might indeed be able to nail this done a bit more.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/58/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/1170/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/58/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/60/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/58/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/58/console

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:147
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/165/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/1180/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/165/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/165/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/165/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/165/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/165/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:148
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/166/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1181
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-ci/166
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/166
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/166
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/166

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/166/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/59/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/1183
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/59
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/61
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/59
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/59

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/60/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/1184
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/60
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/62
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/60
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/60

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:145
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/170/
Executed test runs:
    None: http://91.189.93.70:8080/job/generic-mediumtests/1205/console
    None: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-ci/170/console
    None: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/170/console
    None: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/170/console
    None: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/4/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/170/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/61/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1207
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/61/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/63/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/61
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/61
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-autolanding/1

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:145
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/176/
Executed test runs:

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/176/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:145
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/177/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1226
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/177
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/177
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/11

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/177/rebuild

review: Approve (continuous-integration)

=== modified file 'MonthComponent.qml'
--- MonthComponent.qml	2013-10-16 14:36:51 +0000
+++ MonthComponent.qml	2013-10-22 17:53:22 +0000
@@ -64,6 +64,7 @@
 
             Grid{
                 id: monthGrid
+                objectName: "monthGrid"
 
                 property int weekCount : 6
                 property var monthStart: root.monthDate.weekStart( Qt.locale().firstDayOfWeek )

=== modified file 'ViewHeader.qml'
--- ViewHeader.qml	2013-10-09 03:01:45 +0000
+++ ViewHeader.qml	2013-10-22 17:53:22 +0000
@@ -12,6 +12,7 @@
 
     Label{
         id: monthLabel
+        objectName: "monthLabel"
         fontSize: monthLabelFontSize
         text: Qt.locale().standaloneMonthName(date.getMonth())
         anchors.leftMargin: units.gu(1)
@@ -22,6 +23,7 @@
 
     Label{
         id: yearLabel
+        objectName: "yearLabel"
         fontSize: yearLabelFontSize
         text: date.getFullYear()
         anchors.right: parent.right

=== modified file 'calendar.qml'
--- calendar.qml	2013-10-16 14:15:06 +0000
+++ calendar.qml	2013-10-22 17:53:22 +0000
@@ -231,8 +231,10 @@
             Tabs{
                 id: tabs
                 Tab{
+                    objectName: "yearTab"
                     title: i18n.tr("Year")
                     page: Page{
+                        objectName: "yearPage"
                         anchors.fill: parent
                         tools: commonToolBar
                         YearView{

=== modified file 'tests/autopilot/calendar_app/emulators.py'
--- tests/autopilot/calendar_app/emulators.py	2013-10-05 07:50:54 +0000
+++ tests/autopilot/calendar_app/emulators.py	2013-10-22 17:53:22 +0000
@@ -67,3 +67,21 @@
 
     def get_time_picker(self):
         return self.select_single("TimePicker")
+
+    def swipe_view(self, direction, view, x_pad=0.35):
+        """Swipe the given view to left or right.
+
+        Args:
+            direction: if 1 it swipes from right to left, if -1 from
+                left right.
+
+        """
+
+        start = (-direction * x_pad) % 1
+        stop = (direction * x_pad) % 1
+
+        y_line = view.globalRect[1] + view.globalRect[3] / 2
+        x_start = view.globalRect[0] + view.globalRect[2] * start
+        x_stop = view.globalRect[0] + view.globalRect[2] * stop
+
+        self.pointing_device.drag(x_start, y_line, x_stop, y_line)

=== modified file 'tests/autopilot/calendar_app/tests/test_monthview.py'
--- tests/autopilot/calendar_app/tests/test_monthview.py	2013-10-01 16:15:42 +0000
+++ tests/autopilot/calendar_app/tests/test_monthview.py	2013-10-22 17:53:22 +0000
@@ -28,17 +28,13 @@
 
     def change_month(self, delta):
         month_view = self.main_view.get_month_view()
-        y_line = month_view.globalRect[1] + month_view.globalRect[3] / 2
-        x_pad = 0.35
         sign = int(math.copysign(1, delta))
-        start = (-sign * x_pad) % 1
-        stop = (sign * x_pad) % 1
-        x_start = month_view.globalRect[0] + month_view.globalRect[2] * start
-        x_stop = month_view.globalRect[0] + month_view.globalRect[2] * stop
-        for i in range(abs(delta)):
+
+        for _ in range(abs(delta)):
             before = self.get_currentDayStart()
-            self.pointing_device.drag(x_start, y_line, x_stop, y_line)
+            self.main_view.swipe_view(sign, month_view)
             after = before + relativedelta(months=sign)
+
             self.assertThat(lambda: self.get_currentDayStart().month,
                             Eventually(Equals(after.month)))
             self.assertThat(lambda: self.get_currentDayStart().year,

=== added file 'tests/autopilot/calendar_app/tests/test_yearview.py'
--- tests/autopilot/calendar_app/tests/test_yearview.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/calendar_app/tests/test_yearview.py	2013-10-22 17:53:22 +0000
@@ -0,0 +1,107 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2013 Canonical
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+
+"""
+Calendar app autopilot tests for the year view.
+"""
+
+from datetime import datetime
+
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals, NotEquals
+
+from calendar_app.tests import CalendarTestCase
+
+
+class TestYearView(CalendarTestCase):
+
+    def setUp(self):
+        super(TestYearView, self).setUp()
+        self.assertThat(self.main_view.visible, Eventually(Equals(True)))
+        self.main_view.switch_to_tab("yearTab")
+        self.assertThat(
+            self.main_view.get_year_view, Eventually(NotEquals(None)))
+
+        self.year_view = self.main_view.get_year_view()
+
+    def test_selecting_a_month_switch_to_month_view(self):
+        """It must be possible to select a month and open the month view."""
+
+        months = self.months_from_selected_year()
+        self.assert_current_year_is_default_one(months[0])
+
+        february = months[1]
+        expected_month_name = self.get_month_name(february)
+        expected_year = self.get_year(february)
+
+        self.pointing_device.click_object(february)
+
+        self.assertThat(
+            self.main_view.get_month_view, Eventually(NotEquals(None)))
+
+        month_view = self.main_view.get_month_view()
+        self.assertThat(month_view.visible, Eventually(Equals(True)))
+        selected_month = month_view.select_many("MonthComponent")[1]
+
+        self.assertThat(self.get_year(selected_month), Equals(expected_year))
+        self.assertThat(self.get_month_name(selected_month),
+                        Equals(expected_month_name))
+
+    def test_current_day_is_selected(self):
+        """The current day must be selected."""
+
+        months = self.months_from_selected_year()
+        current_month = months[datetime.now().month - 1]
+        month_grid = current_month.select_single(objectName="monthGrid")
+
+        current_day_label = month_grid.select_single(
+            "Label", text=str(datetime.now().day))
+
+        # probably better to check the surrounding UbuntuShape object,
+        # upgrade when python-autopilot 1.4 will be available (get_parent).
+        color = current_day_label.color
+        label_color = (color[0], color[1], color[2], color[3])
+
+        self.assertThat(label_color, NotEquals((255, 255, 255, 255)))
+
+    def test_show_next_years(self):
+        """It must be possible to show next years by swiping the view."""
+        self.change_year(1)
+
+    def test_show_previous_years(self):
+        """It must be possible to show previous years by swiping the view."""
+        self.change_year(-1)
+
+    def change_year(self, direction, how_many=5):
+        current_year = datetime.now().year
+
+        for i in xrange(1, how_many):
+            self.main_view.swipe_view(direction, self.year_view, x_pad=0.15)
+            selected_year = datetime.fromtimestamp(
+                self.year_view.currentYear).year
+
+            self.assertThat(
+                selected_year, Equals(current_year + (i * direction)))
+
+    def assert_current_year_is_default_one(self, month_component):
+        self.assertThat(self.get_year(month_component),
+                        Equals(datetime.now().year))
+
+    def get_year(self, month_component):
+        return int(month_component.select_single(
+            "Label", objectName="yearLabel").text)
+
+    def get_month_name(self, month_component):
+        return month_component.select_single(
+            "Label", objectName="monthLabel").text
+
+    def months_from_selected_year(self):
+        # TODO: the component indexed at 1 is the one currently displayed,
+        # investigate a way to validate this assumption visually.
+
+        year_grid = self.year_view.select_many("QQuickGridView")[1]
+        return year_grid.select_many("MonthComponent")