Merge lp:~acerisara/ubuntu-calendar-app/test-new-event-failing into lp:ubuntu-calendar-app

Proposed by Andrea Cerisara
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 159
Merged at revision: 161
Proposed branch: lp:~acerisara/ubuntu-calendar-app/test-new-event-failing
Merge into: lp:ubuntu-calendar-app
Diff against target: 28 lines (+7/-2)
1 file modified
tests/autopilot/calendar_app/tests/test_calendar.py (+7/-2)
To merge this branch: bzr merge lp:~acerisara/ubuntu-calendar-app/test-new-event-failing
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calendar Developers Pending
Review via email: mp+192398@code.launchpad.net

Commit message

Fixed unstable autopilot test_new_event.

Description of the change

Trying to fix the randomly failing test_new_event on CI (it works well locally).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/tests/test_calendar.py'
2--- tests/autopilot/calendar_app/tests/test_calendar.py 2013-10-09 01:01:02 +0000
3+++ tests/autopilot/calendar_app/tests/test_calendar.py 2013-10-23 20:47:34 +0000
4@@ -27,8 +27,11 @@
5 y = int(scroller.globalRect[1] + 0.9 * scroller.globalRect[3])
6 self.pointing_device.move(x, y)
7 while (scroller.currentIndex != hours):
8+ current_index = scroller.currentIndex
9 self.pointing_device.click()
10- scroller.currentIndex.wait_for((scroller.currentIndex + 1) % 24)
11+ self.assertThat(scroller.currentIndex, Eventually(
12+ Equals((current_index + 1) % 24)))
13+
14 # Scroll minutes to selected value
15 scroller = picker.select_single("Scroller",
16 objectName="minuteScroller")
17@@ -36,8 +39,10 @@
18 y = int(scroller.globalRect[1] + 0.9 * scroller.globalRect[3])
19 self.pointing_device.move(x, y)
20 while (scroller.currentIndex != minutes):
21+ current_index = scroller.currentIndex
22 self.pointing_device.click()
23- scroller.currentIndex.wait_for((scroller.currentIndex + 1) % 60)
24+ self.assertThat(scroller.currentIndex, Eventually(
25+ Equals((current_index + 1) % 60)))
26
27 def hideOSK(self):
28 start_time_field = self.main_view.get_event_start_time_field()

Subscribers

People subscribed via source and target branches

to status/vote changes: