Merge lp:~acerisara/ubuntu-calendar-app/WeekView-ScrollToToday into lp:ubuntu-calendar-app

Proposed by Andrea Cerisara
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 570
Merged at revision: 592
Proposed branch: lp:~acerisara/ubuntu-calendar-app/WeekView-ScrollToToday
Merge into: lp:ubuntu-calendar-app
Prerequisite: lp:~pkunal-parmar/ubuntu-calendar-app/WeekView-ScrollToToday
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/calendar_app/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~acerisara/ubuntu-calendar-app/WeekView-ScrollToToday
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Kunal Parmar Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calendar Developers Pending
Review via email: mp+249018@code.launchpad.net

Commit message

Reduced x_pad paremeter for swipe.

Description of the change

Test with a different value for the x_pad parameter.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

Looks fine to me

review: Needs Fixing
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

Sorry something went wrong

review: Approve
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM; xpad was often funny, so I would caution to check the result on the device, but if this helps then +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/__init__.py'
2--- tests/autopilot/calendar_app/__init__.py 2015-02-08 19:40:54 +0000
3+++ tests/autopilot/calendar_app/__init__.py 2015-02-08 19:40:54 +0000
4@@ -214,7 +214,7 @@
5 sleep(1)
6 timeout += 1
7
8- def swipe_view(self, direction, view, x_pad=0.20):
9+ def swipe_view(self, direction, view, x_pad=0.08):
10 """Swipe the given view to left or right.
11
12 Args:

Subscribers

People subscribed via source and target branches

to status/vote changes: