Merge ~acelankao/ubuntu/+source/firmware-sof:jammy-devel into ubuntu/+source/firmware-sof:ubuntu/jammy-devel
Proposed by
AceLan Kao
| Status: | Needs review |
|---|---|
| Proposed branch: | ~acelankao/ubuntu/+source/firmware-sof:jammy-devel |
| Merge into: | ubuntu/+source/firmware-sof:ubuntu/jammy-devel |
| Diff against target: |
112 lines (+24/-1) 2 files modified
debian/changelog (+8/-0) debian/source/include-binaries (+16/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andreas Hasenack | Needs Fixing | ||
| git-ubuntu import | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged commits
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I believe this was uploaded already, as I see it in jammy-unapprove
It doesn't match this MP, though, at least the d/changelog entry here in the MP is incorrect, as it has "UNRELEASED" instead of "jammy" in the entry.
Besides that, as I stated in the bug[2], I don't know how to review firmware changes. I don't know where the binary blobs *.tplg come from.
I'll mark this as "needs fixing" due to the changelog entry, but I personally cannot make further progress in this review due to my limited knowledge about this package.
I just noticed another MP against this same package, at [3]. It's using the same version for the package as this one, should they be merged?
1. https:/
2. https:/
3. https:/