signond:fixcrashonclose

Last commit made on 2015-01-30
Get this branch:
git clone -b fixcrashonclose https://git.launchpad.net/signond

Branch merges

Branch information

Name:
fixcrashonclose
Repository:
lp:signond

Recent commits

fccdfba... by Chris Adams

signond: Initialize private member ptr in ctor to avoid crash

This commit initializes the m_secretsDB member of the default secrets
storage class to avoid spurious close() on invalid pointer.

It also ensures that the database name and connection name strings
for the default secrets storage database are detached from their
source strings, in case their source string is a QStringLiteral which
comes from a plugin which gets unloaded prior to the dtor being called.

2f072a1... by Chris Adams

signond: Continue reading from plugins after handling response if necessary

There may be more than one response from the plugin; for example, during
a refresh, you receive a store and result response. If both arrive
simultaniously, readyRead() will not be signalled again after handling
the first response. The request will then be deadlocked waiting for a
response that is sitting in the file buffer.

The immediate solution is simply to read again if there's more to be
read after handling a response.

Author: John Brooks <email address hidden>
Date: Wed Nov 6 02:14:53 2013 -0700

3ef0a6b... by Alberto Mardegan

Tests: fix tst_access_control_manager_helper

The .cpp file was being included by mistake.

568d180... by Alberto Mardegan

Tests: add tst_access_control_manager_helper

4b025a9... by Alberto Mardegan

Tests: set ACL on new identities

Explicitly set the ACL to "*" on new identities.
Slightly refactor a couple of unit tests.

76e132a... by Alberto Mardegan

signond: on identity update, don't reset missing fields

When Identtity::store() is being called on an existing identity, do not
touch the fields which are not present in the new dictionary of identity
info. Before this commit, all fields which were not present in the new
identity data would be reset to their default value.

03dd20e... by Alberto Mardegan

signond: don't bypass the ACL if the identity has no owner

631eff5... by Alberto Mardegan

signond: fix typo

81aaac9... by Alberto Mardegan

signond: pass client AppId to SignOnUi

ea3e192... by Alberto Mardegan

signond: pass the client PID to SignOnUI

This can be useful under the Mir display server, where single-window
apps are referred to by PID.