Merge lp:~abychko/percona-xtradb-cluster/bug1128906 into lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5

Proposed by Alexey Bychko
Status: Merged
Merged at revision: 387
Proposed branch: lp:~abychko/percona-xtradb-cluster/bug1128906
Merge into: lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5
Diff against target: 56 lines (+10/-8)
3 files modified
Percona-Server/cmake/wsrep.cmake (+1/-1)
build/build-rpm.sh (+6/-6)
build/percona-xtradb-cluster.spec (+3/-1)
To merge this branch: bzr merge lp:~abychko/percona-xtradb-cluster/bug1128906
Reviewer Review Type Date Requested Status
Raghavendra D Prabhu (community) Approve
Vadim Tkachenko Pending
Review via email: mp+149210@code.launchpad.net

This proposal supersedes a proposal from 2013-02-19.

Description of the change

to fix rpm names like Percona-XtraDB-Cluster-server-5.5.29-%{wsrep_version}.1.rhel6.x86_64.rpm

[+] added released wsrep version 23.7.2 if wsrep version is not defined

To post a comment you must log in.
Revision history for this message
Vadim Tkachenko (vadim-tk) wrote : Posted in a previous version of this proposal

There already 23.7.2 released

review: Needs Fixing
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

@AlexeyB,

Is it possible to not bump the version in this patch (it is maintained upstream)?

Revision history for this message
Alexey Bychko (abychko) wrote :

yes. but PXC with 7.2 already released and RPM built from src.rpm will have wrong version. details from Vadim

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

I got this conflict from the merge https://gist.github.com/b506feba3af7f4066b26

I resolved it and merged it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/cmake/wsrep.cmake'
2--- Percona-Server/cmake/wsrep.cmake 2013-02-06 17:19:28 +0000
3+++ Percona-Server/cmake/wsrep.cmake 2013-02-19 08:51:24 +0000
4@@ -17,7 +17,7 @@
5 # so WSREP_VERSION is produced regardless
6
7 # Set the patch version
8-SET(WSREP_PATCH_VERSION "7.1")
9+SET(WSREP_PATCH_VERSION "7.2")
10
11 # Obtain patch revision number
12 SET(WSREP_PATCH_REVNO $ENV{WSREP_REV})
13
14=== modified file 'build/build-rpm.sh'
15--- build/build-rpm.sh 2012-11-13 17:26:18 +0000
16+++ build/build-rpm.sh 2013-02-19 08:51:24 +0000
17@@ -1,4 +1,4 @@
18-#!/bin/sh
19+#!/bin/bash
20 #
21 # Execute this tool to setup and build RPMs for Percona XtraDB Cluster
22 # from a fresh tree
23@@ -148,13 +148,13 @@
24 # Issue rpmbuild command
25 (
26 cd "$WORKDIR"
27-
28+ sed -e "s:@@WSREP_VERSION@@:${WSREP_VERSION}:g" \
29+ "$SOURCEDIR/build/percona-xtradb-cluster.spec" > \
30+ "${WORKDIR_ABS}/SPECS/percona-xtradb-cluster.spec"
31 # Issue RPM command
32 rpmbuild -ba --clean --with yassl $TARGET $SIGN $QUIET \
33- "$SOURCEDIR/build/percona-xtradb-cluster.spec" \
34+ "${WORKDIR_ABS}/SPECS/percona-xtradb-cluster.spec" \
35 --define "_topdir $WORKDIR_ABS" \
36- --define "revision $REVISION" \
37- --define "wsrep_version $WSREP_VERSION"
38-
39+ --define "revision $REVISION"
40 )
41
42
43=== modified file 'build/percona-xtradb-cluster.spec'
44--- build/percona-xtradb-cluster.spec 2013-01-25 01:53:12 +0000
45+++ build/percona-xtradb-cluster.spec 2013-02-19 08:51:24 +0000
46@@ -35,7 +35,9 @@
47 %define mysqld_user mysql
48 %define mysqld_group mysql
49 %define mysqldatadir /var/lib/mysql
50-
51+#
52+%{!?wsrep_version:%global wsrep_version @@WSREP_VERSION@@}
53+#
54 %if %{undefined revision}
55 %define revision 1
56 %endif

Subscribers

People subscribed via source and target branches

to all changes: