Code review comment for lp:~abychko/percona-server/bug1103328

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Mostly OK, but whitespace issue at diff lines 41--42.

I am also nervous about diverging from the upstream behaviour by making WITH_VALGRIND fatal in the absence of Valgrind headers. Should be OK, but please get a second opinion.

review: Needs Fixing

« Back to merge proposal