Merge lp:~abychko/percona-server/5.6-new-packaging-Stewart into lp:percona-server/5.6

Proposed by Alexey Bychko
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 537
Proposed branch: lp:~abychko/percona-server/5.6-new-packaging-Stewart
Merge into: lp:percona-server/5.6
Diff against target: 194 lines (+33/-45)
5 files modified
README (+3/-3)
build-ps/debian/control (+1/-1)
build-ps/debian/rules (+6/-8)
build-ps/percona-server.spec (+22/-31)
cmake/ssl.cmake (+1/-2)
To merge this branch: bzr merge lp:~abychko/percona-server/5.6-new-packaging-Stewart
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+203358@code.launchpad.net

Description of the change

fixed packaging from Stewart

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2013-11-15 03:29:06 +0000
3+++ README 2014-01-28 10:44:01 +0000
4@@ -1,11 +1,11 @@
5-Percona Server 5.5
6+Percona Server 5.6
7 ------------------
8
9-Percona Server is a branch of MySQL 5.5 bringing higher performance,
10+Percona Server is a branch of MySQL 5.6 bringing higher performance,
11 reliability and more features.
12
13 http://www.percona.com/software/percona-server/
14
15-Documentation: http://www.percona.com/doc/percona-server/5.5
16+Documentation: http://www.percona.com/doc/percona-server/5.6
17
18 Launchpad (bugs, milestones, branches): http://launchpad.net/percona-server
19
20=== modified file 'build-ps/debian/control'
21--- build-ps/debian/control 2013-12-22 23:31:06 +0000
22+++ build-ps/debian/control 2014-01-28 10:44:01 +0000
23@@ -3,7 +3,7 @@
24 Priority: extra
25 Maintainer: Percona Server Development Team <mysql-dev@percona.com>
26 Uploaders: Stewart Smith <stewart.smith@percona.com>, Alexey Bychko <alexey.bychko@percona.com>
27-Build-Depends: libtool (>= 1.4.2-7), procps | hurd, debhelper (>= 8.1.3~), file (>= 3.28), libncurses5-dev (>= 5.0-6), perl (>= 5.6.0), libwrap0-dev (>= 7.6-8.3), zlib1g-dev (>= 1:1.1.3-5), libreadline-dev, psmisc, po-debconf, chrpath, doxygen-latex, ghostscript, gawk, bison, lsb-release, hardening-wrapper, cmake, dh-apparmor, gcc-4.4 [any-i386], g++-4.4 [any-i386], libaio-dev[linux-any], libpam-dev, libssl-dev
28+Build-Depends: libtool (>= 1.4.2-7), procps | hurd, debhelper, file (>= 3.28), libncurses5-dev (>= 5.0-6), perl (>= 5.6.0), libwrap0-dev (>= 7.6-8.3), zlib1g-dev (>= 1:1.1.3-5), libreadline-dev, psmisc, po-debconf, chrpath, ghostscript, gawk, bison, lsb-release, cmake, gcc, g++, libaio-dev[linux-any], libpam-dev, libssl-dev
29 Standards-Version: 3.9.4
30 Homepage: http://www.percona.com/software/percona-server/
31 Vcs-Bzr: lp:percona-server/5.6
32
33=== modified file 'build-ps/debian/rules'
34--- build-ps/debian/rules 2014-01-15 08:49:17 +0000
35+++ build-ps/debian/rules 2014-01-28 10:44:01 +0000
36@@ -14,9 +14,9 @@
37 DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
38 DEBVERSION = $(shell dpkg-parsechangelog | awk '/^Version: / { print $$2 }' | sed 's/^.*-//' )
39
40-ifneq (,$(filter $(ARCH), i386 kfreebsd-i386 hurd-i386))
41- USE_THIS_GCC_VERSION:=-4.4
42-endif
43+#ifneq (,$(filter $(ARCH), i386 kfreebsd-i386 hurd-i386))
44+# USE_THIS_GCC_VERSION:=-4.4
45+#endif
46
47 export MYSQL_BUILD_CC=$(DEB_HOST_GNU_TYPE)-gcc$(USE_THIS_GCC_VERSION)
48 export MYSQL_BUILD_CXX=$(DEB_HOST_GNU_TYPE)-g++$(USE_THIS_GCC_VERSION)
49@@ -35,7 +35,7 @@
50
51 MYSQL_SRC = $(shell pwd)
52
53-MAKE_TEST_TARGET=test-mtr
54+#MAKE_TEST_TARGET=test-mtr
55 ifneq ($(findstring fulltest,$(DEB_BUILD_OPTIONS)),)
56 # make test-bt is the testsuite run by the MySQL build team
57 # before a release, but it is long
58@@ -92,7 +92,7 @@
59 $(USE_STATIC_MYSQLD) \
60 $(USE_LINUX_NATIVE_AIO) \
61 -DWITH_ZLIB=system \
62- -DWITH_SSL=bundled \
63+ -DWITH_SSL=system \
64 -DCOMPILATION_COMMENT="($(DISTRIBUTION))" \
65 -DMYSQL_SERVER_SUFFIX="-$(DEBVERSION)" \
66 -DSYSTEM_TYPE="debian-linux-gnu" \
67@@ -268,9 +268,7 @@
68 dh_installexamples -a
69 dh_installmenu -a
70 dh_installlogrotate -a --name mysql-server
71- if [ "$(DISTRIBUTION)" = "Ubuntu" ]; then \
72- dh_apparmor -pmysql-server-5.6 --profile-name=usr.sbin.mysqld; \
73- fi
74+ if [ "$(DISTRIBUTION)" = "Ubuntu" ]; then if [ "$(DISTRELEASE)" != "lucid"]; then dh_apparmor -pmysql-server-5.5 --profile-name=usr.sbin.mysqld; fi; fi
75 # Start mysql in runlevel 19 before 20 where apache, proftpd etc gets
76 # started which might depend on a running database server.
77 dh_installinit -a --name=mysql -- defaults 19 21
78
79=== modified file 'build-ps/percona-server.spec'
80--- build-ps/percona-server.spec 2014-01-16 05:48:56 +0000
81+++ build-ps/percona-server.spec 2014-01-28 10:44:01 +0000
82@@ -25,17 +25,15 @@
83 %define mysql_vendor Oracle and/or its affiliates
84 %define percona_server_vendor Percona, Inc
85
86-%define mysql_version 5.6.15
87+%define mysql_version @@MYSQL_VERSION@@
88 %define redhatversion %(lsb_release -rs | awk -F. '{ print $1}')
89-%define majorversion 62
90-%define minorversion 0
91-%define percona_server_version %{majorversion}.%{minorversion}
92+%define percona_server_version @@PERCONA_VERSION@@
93
94 %define mysqld_user mysql
95 %define mysqld_group mysql
96 %define mysqldatadir /var/lib/mysql
97
98-%define release rel%{majorversion}.%{minorversion}.1%{?dist}
99+%define release rel%{percona_server_version}.1%{?dist}
100
101 #
102 # Macros we use which are not available in all supported versions of RPM
103@@ -227,7 +225,7 @@
104 Release: %{release}
105 Distribution: %{distro_description}
106 License: Copyright (c) 2000, 2010, %{mysql_vendor}. All rights reserved. Use is subject to license terms. Under %{license_type} license as shown in the Description field.
107-Source: http://www.percona.com/downloads/Percona-Server-5.6/Percona-Server-%{mysql_version}-%{majorversion}.%{minorversion}/source/%{src_dir}.tar.gz
108+Source: http://www.percona.com/downloads/Percona-Server-5.6/Percona-Server-%{mysql_version}-%{percona_server_version}/source/%{src_dir}.tar.gz
109 URL: http://www.percona.com/
110 Packager: Percona MySQL Development Team <mysqldev@percona.com>
111 Vendor: %{percona_server_vendor}
112@@ -364,10 +362,12 @@
113 %if "%{_arch}" == "ia64"
114 RPM_OPT_FLAGS=
115 %endif
116-
117+#
118+RPM_OPT_FLAGS=$(echo ${RPM_OPT_FLAGS} | sed -e 's|-march=i386|-march=i686|g')
119+#
120 export PATH=${MYSQL_BUILD_PATH:-$PATH}
121 export CC=${MYSQL_BUILD_CC:-${CC:-gcc}}
122-export CXX=${MYSQL_BUILD_CXX:-${CXX:-gcc}}
123+export CXX=${MYSQL_BUILD_CXX:-${CXX:-g++}}
124 export CFLAGS=${MYSQL_BUILD_CFLAGS:-${CFLAGS:-$RPM_OPT_FLAGS}}
125 export CXXFLAGS=${MYSQL_BUILD_CXXFLAGS:-${CXXFLAGS:-$RPM_OPT_FLAGS -felide-constructors -fno-rtti}}
126 export LDFLAGS=${MYSQL_BUILD_LDFLAGS:-${LDFLAGS:-}}
127@@ -463,33 +463,11 @@
128 # Clean up the BuildRoot first
129 [ "$RBR" != "/" ] && [ -d "$RBR" ] && rm -rf "$RBR";
130
131-# For gcc builds, include libgcc.a in the devel subpackage (BUG 4921). This
132-# needs to be during build phase as $CC is not set during install.
133-if "$CC" -v 2>&1 | grep '^gcc.version' >/dev/null 2>&1
134-then
135- libgcc=`$CC $CFLAGS --print-libgcc-file`
136- if [ -f $libgcc ]
137- then
138- mkdir -p $RBR%{_libdir}/mysql
139- install -m 644 $libgcc $RBR%{_libdir}/mysql/libmygcc.a
140- echo "%{_libdir}/mysql/libmygcc.a" >>optional-files-devel
141- fi
142-fi
143-
144-# Move temporarily the saved files to the BUILD directory since the BUILDROOT
145-# dir will be cleaned at the start of the install phase
146-mkdir -p "$RPM_BUILD_DIR/%{_libdir}"
147-mv $RBR%{_libdir} $RPM_BUILD_DIR/%{_libdir}
148-
149 ##############################################################################
150 %install
151
152 RBR=$RPM_BUILD_ROOT
153-MBD=$RPM_BUILD_DIR/percona-server-%{mysql_version}%{server_suffix}
154-
155-# Move back the libdir from BUILD dir to BUILDROOT
156-mkdir -p "$RBR%{_libdir}"
157-mv $RPM_BUILD_DIR/%{_libdir} $RBR%{_libdir}
158+MBD=$RPM_BUILD_DIR/percona-server-%{mysql_version}-%{percona_server_version}
159
160 # Ensure that needed directories exists
161 install -d $RBR%{_sysconfdir}/{logrotate.d,init.d}
162@@ -517,6 +495,19 @@
163 make DESTDIR=$RBR install
164 )
165
166+# For gcc builds, include libgcc.a in the devel subpackage (BUG 4921). This
167+# needs to be during build phase as $CC is not set during install.
168+if "$CC" -v 2>&1 | grep '^gcc.version' >/dev/null 2>&1
169+then
170+ libgcc=`$CC $CFLAGS --print-libgcc-file`
171+ if [ -f $libgcc ]
172+ then
173+ mkdir -p $RBR%{_libdir}/mysql
174+ install -m 644 $libgcc $RBR%{_libdir}/mysql/libmygcc.a
175+ echo "%{_libdir}/mysql/libmygcc.a" >>optional-files-devel
176+ fi
177+fi
178+
179 # FIXME: at some point we should stop doing this and just install everything
180 # FIXME: directly into %{_libdir}/mysql - perhaps at the same time as renaming
181 # FIXME: the shared libraries to use libmysql*-$major.$minor.so syntax
182
183=== modified file 'cmake/ssl.cmake'
184--- cmake/ssl.cmake 2013-06-01 05:18:49 +0000
185+++ cmake/ssl.cmake 2014-01-28 10:44:01 +0000
186@@ -232,8 +232,7 @@
187 MYSQL_USE_BUNDLED_SSL()
188 ENDIF()
189 ELSE()
190- MESSAGE(SEND_ERROR
191- "Wrong option for WITH_SSL. Valid values are : "${WITH_SSL_DOC})
192+ MESSAGE(SEND_ERROR "Wrong option for WITH_SSL. Valid values are: " ${WITH_SSL_DOC})
193 ENDIF()
194 ENDMACRO()
195

Subscribers

People subscribed via source and target branches