Merge lp:~abreu-alexandre/webbrowser-app/with-oxide into lp:~osomon/webbrowser-app/with-oxide

[Alexandre Abreu]

Container updates: Enable localstorage + some fixes

Container updates: Enable localstorage + some fixes

[Olivier Tilloy (osomon)]

Do we need https://code.launchpad.net/~abreu-alexandre/unity-webapps-qml/oxide-integration/+merge/211615 to land first as a prerequisite, or does the landing order not matter?

review: Needs Information

[Alexandre Abreu (abreu-alexandre)]

> Do we need https://code.launchpad.net/~abreu-alexandre/unity-webapps-qml
> /oxide-integration/+merge/211615 to land first as a prerequisite, or does the
> landing order not matter?

Does not matter really there are no deps between the 2, but this fixes an issue further down the webapps chain where quite a few webapps use localStorage

[Alexandre Abreu (abreu-alexandre)]

> > Do we need https://code.launchpad.net/~abreu-alexandre/unity-webapps-qml
> > /oxide-integration/+merge/211615 to land first as a prerequisite, or does
> the
> > landing order not matter?
>
> Does not matter really there are no deps between the 2, but this fixes an
> issue further down the webapps chain where quite a few webapps use
> localStorage

You are right indeed, I missed/forgot the makeProxiesForWebViewBindee part,
yes there is a landing deps on https://code.launchpad.net/~abreu-alexandre/unity-webapps-qml
> /oxide-integration/+merge/211615

[Olivier Tilloy (osomon)]

Good. As long as the two MRs land together we should be fine. The change looks good to me.

review: Approve

=== modified file 'src/app/webcontainer/WebApp.qml'
--- src/app/webcontainer/WebApp.qml	2014-03-17 22:16:59 +0000
+++ src/app/webcontainer/WebApp.qml	2014-03-18 19:48:53 +0000
@@ -69,8 +69,6 @@
             }
             height: parent.height - osk.height
 
-            //experimental.preferences.developerExtrasEnabled: developerExtrasEnabled
-
             contextualActions: ActionList {
                 Actions.CopyLink {
                     enabled: webview.contextualData.href.toString()
@@ -116,6 +114,8 @@
 
             onNewTabRequested: Qt.openUrlExternally(url)
 
+	    preferences.localStorageEnabled: true
+
             // Small shim needed when running as a webapp to wire-up connections
             // with the webview (message received, etc…).
             // This is being called (and expected) internally by the webapps
@@ -133,7 +133,7 @@
                         }
                     }
                 };
-                return UnityWebAppsUtils.makeProxiesForQtWebViewBindee(webview, eventHandlers)
+                return UnityWebAppsUtils.makeProxiesForWebViewBindee(webview, eventHandlers)
             }
         }