webbrowser-app

Code review comment for lp:~abreu-alexandre/webbrowser-app/support-oxide-and-qtwebkit

  1. support-oxide-and-qtwebkit
  2. Merge into with-oxide
Revision history for this message
Olivier Tilloy (osomon) wrote :

287 + experimental.preferences.developerExtrasEnabled: developerExtrasEnabled

"developerExtrasEnabled" is not defined in this context (this might actually work because it is defined in a parent context, but it breaks encapsulation, thus making the code hard to read and to maintain).
Can you make it a property of the WebViewImplWebkit and ensure it’s set from the caller?

« Back to merge proposal