Merge lp:~abreu-alexandre/webbrowser-app/specify-embedded-ui-parent into lp:webbrowser-app

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 1368
Merged at revision: 1442
Proposed branch: lp:~abreu-alexandre/webbrowser-app/specify-embedded-ui-parent
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/app/webcontainer/WebApp.qml (+1/-0)
To merge this branch: bzr merge lp:~abreu-alexandre/webbrowser-app/specify-embedded-ui-parent
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287358@code.launchpad.net

Commit message

Specify a parent for embedded uis being launched by webapps

Description of the change

Specify a parent for embedded uis being launched by webapps

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webcontainer/WebApp.qml'
2--- src/app/webcontainer/WebApp.qml 2016-02-09 17:04:23 +0000
3+++ src/app/webcontainer/WebApp.qml 2016-02-26 19:31:10 +0000
4@@ -260,6 +260,7 @@
5 id: unityWebapps
6 name: webappName
7 bindee: containerWebView.currentWebview
8+ embeddedUiComponentParent: webapp
9 actionsContext: actionManager.globalContext
10 model: UnityWebApps.UnityWebappsAppModel { searchPath: webappModelSearchPath }
11 injectExtraUbuntuApis: runningLocalApplication

Subscribers

People subscribed via source and target branches

to status/vote changes: