webbrowser-app

Merge lp:~abreu-alexandre/webbrowser-app/new-tab-requested-when-in-webapp-mode into lp:webbrowser-app

  1. new-tab-requested-when-in-webapp-mode
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 359
Merged at revision: 362
Proposed branch: lp:~abreu-alexandre/webbrowser-app/new-tab-requested-when-in-webapp-mode
Merge into: lp:webbrowser-app
Diff against target: 20 lines (+9/-1)
1 file modified
src/app/Browser.qml (+9/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/webbrowser-app/new-tab-requested-when-in-webapp-mode
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Barth (community) Approve
Review via email: mp+188674@code.launchpad.net

Commit message

When the browser is requested to create a new tab (from a new window request), open the new tab externally when in webapp mode.

Description of the change

When the browser is requested to create a new tab (from a new window request), open the new tab externally when in webapp mode.

To post a comment you must log in.
lp:~abreu-alexandre/webbrowser-app/new-tab-requested-when-in-webapp-mode updated
359. By Alexandre Abreu

Handle the case of a new tab requested when in a webapp mode

Revision history for this message
David Barth (dbarth) wrote :

Issue fixed with this change.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:358
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/443/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4297
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2004
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/327/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/326
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/326/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/326
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/586
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/166
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/166/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2006
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2006/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1694
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1711

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/443/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/445/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4305
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2014
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/328
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/328/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/328
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/595
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/175
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/175/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2016
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2016/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1704
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1721

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/445/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/447/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4341
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2050
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/331
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/330
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/330/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/330
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/628
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/215
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/215/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2052
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2052/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1739
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1757

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/447/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/449/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4351
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2071
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/333
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/332
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/332/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/332
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/637
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/225
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/225/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2073
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2073/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1761
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1778

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/449/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/451/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2087
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/335
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/334
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/334/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/334
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/647
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/236
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/236/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2089
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2089/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1774
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1791

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/451/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/Browser.qml'
2--- src/app/Browser.qml 2013-09-26 02:27:18 +0000
3+++ src/app/Browser.qml 2013-10-01 18:29:41 +0000
4@@ -449,7 +449,15 @@
5 }
6 }
7
8- onNewTabRequested: browser.newTab(url, true)
9+ onNewTabRequested: {
10+
11+ if (webapp) {
12+ Qt.openUrlExternally(url);
13+ }
14+ else {
15+ browser.newTab(url, true);
16+ }
17+ }
18
19 // Small shim needed when running as a webapp to wire-up connections
20 // with the webview (message received, etc…).

Subscribers

People subscribed via source and target branches

to status/vote changes: