Merge lp:~abreu-alexandre/webbrowser-app/fix-url-opening into lp:webbrowser-app
Proposed by
Alexandre Abreu
Status: | Merged |
---|---|
Approved by: | Olivier Tilloy |
Approved revision: | 718 |
Merged at revision: | 726 |
Proposed branch: | lp:~abreu-alexandre/webbrowser-app/fix-url-opening |
Merge into: | lp:webbrowser-app |
Diff against target: |
23 lines (+2/-4) 1 file modified
src/app/webcontainer/webapp-container.qml (+2/-4) |
To merge this branch: | bzr merge lp:~abreu-alexandre/webbrowser-app/fix-url-opening |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Fix UriHandler url opening operation for the webapp container.
Description of the change
Fix UriHandler url opening operation.
Test to validate the issue:
-------
- open a webapp (e.g. facebook) and stay on the main page and leave it open,
- create small qml app that would basically trigger the whole url dispatcher loop w/ a call to e.g.
Qt.openUrlExter
- launch the app, trigger the url dispatch w/ the custom url,
- the facebook webapp should pick it up and browse to the url,
To post a comment you must log in.
FAILED: Continuous integration, rev:718 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 1098/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/5074/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- utopic/ 3704 jenkins. qa.ubuntu. com/job/ webbrowser- app-utopic- amd64-ci/ 297 jenkins. qa.ubuntu. com/job/ webbrowser- app-utopic- armhf-ci/ 297 jenkins. qa.ubuntu. com/job/ webbrowser- app-utopic- armhf-ci/ 297/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-utopic- i386-ci/ 297 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/4822/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/6326 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/6326/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 13565 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-utopic/ 3097 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/4015 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/4015/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 1098/rebuild
http://