webbrowser-app

Merge lp:~abreu-alexandre/webbrowser-app/fix-filepicker-timer-accept into lp:webbrowser-app

  1. fix-filepicker-timer-accept
  2. Merge into trunk
Proposed by Alexandre Abreu on 2015-07-15
Status: Rejected
Rejected by: Olivier Tilloy on 2015-08-18
Proposed branch: lp:~abreu-alexandre/webbrowser-app/fix-filepicker-timer-accept
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/app/ContentPickerDialog.qml (+1/-0)
To merge this branch: bzr merge lp:~abreu-alexandre/webbrowser-app/fix-filepicker-timer-accept
Reviewer Review Type Date Requested Status
Olivier Tilloy 2015-07-15 Disapprove on 2015-08-18
PS Jenkins bot continuous-integration Approve on 2015-08-03
Review via email: mp+264834@code.launchpad.net

Commit Message

Fix double accept() time issue that indeed causes races in the file processing

Description of the Change

Fix double accept() time issue that indeed causes races in the file processing

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1096
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1995/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3430
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/749
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/749
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/749/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/749
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2856
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3427
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3427/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21874

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1995/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1096
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2018/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3534
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/772
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/772
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/772/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/772
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2930
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22245

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2018/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1096
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2021/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3553
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/775
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/775/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/775
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2942
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3550
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3550/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22271

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2021/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1096
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2022/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3554
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/776
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/776
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/776/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/776
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2943
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3551
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3551/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22274

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2022/rebuild

review: Needs Fixing (continuous-integration)
Michael Sheldon (michael-sheldon) wrote :

It should be possible to remove the whole acceptTimer hack now and just accept the model when the status changes. We traced the underlying cause of this to the transfer dialog within the peer picker not getting destroyed correctly when its parent was destroyed, leaving the QML engine in an invalid state, this has since been fixed in content-hub.

PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1096
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2023/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/777
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/777
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/777/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/777
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2944
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3552
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3552/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22275

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2023/rebuild

review: Approve (continuous-integration)
Olivier Tilloy (osomon) wrote :
review: Disapprove

Unmerged revisions

1096. By Alexandre Abreu on 2015-07-15

Fix double accept() time issue

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/ContentPickerDialog.qml'
2--- src/app/ContentPickerDialog.qml 2014-08-05 07:27:17 +0000
3+++ src/app/ContentPickerDialog.qml 2015-07-15 13:16:35 +0000
4@@ -94,6 +94,7 @@
5 if(Qt.application.active) {
6 webview.focus = true
7 model.accept(selectedItems)
8+ acceptTimer.stop()
9 }
10 }
11 }

Subscribers

People subscribed via source and target branches

to status/vote changes: