Merge lp:~abreu-alexandre/webbrowser-app/fix-container-ap-tests into lp:webbrowser-app

[Alexandre Abreu]

Fix AP tests for webapp-container

Fix AP tests for webapp-container

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:782
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1235/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6460
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4289/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/434
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/434
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/434/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/434
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6058
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7712
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7712/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15421
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3642/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4683
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4683/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1235/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

This change is obviously good, but it’s not enough to make webapp_container tests pass on device (I’m testing on flo with vivid image #8). I’m seeing the following error:

09:51:06.061 INFO _logging:41 - Starting test webapp_container.tests.test_redirection_pattern.WebappContainerRedirectionPatternTestCase.test_browse_to_redirection_pattern_url
09:51:06.067 WARNING testcase:115 - No tracing available - install the python-autopilot-trace package!
09:51:06.088 WARNING testcase:175 - Process manager backend unavailable, application snapshot support disabled.
09:51:06.099 INFO fake_servers:76 - now serving on port 48459
09:51:06.302 WARNING utilities:263 - WARNING: in file "/usr/lib/python3/dist-packages/webapp_container/tests/__init__.py", line 59 in launch_webcontainer_app
This function is deprecated. Please use 'fixtures.EnvironmentVariable' instead.

09:51:06.309 WARNING utilities:263 - WARNING: in file "/usr/lib/python3/dist-packages/webapp_container/tests/__init__.py", line 59 in launch_webcontainer_app
This function is deprecated. Please use 'fixtures.EnvironmentVariable' instead.

09:51:06.310 INFO _launcher:373 - Attempting to launch application 'b'/usr/bin/webapp-container'' with arguments '--popup-redirection-url-prefix=http://localhost:48459/redirect?url=([^&]*).* http://localhost:48459/get-redirect --desktop_file_hint=/usr/share/applications/webbrowser-app.desktop' as a normal process
09:51:06.356 INFO _launcher:431 - Launching process: ['/usr/bin/webapp-container', '-testability', '--popup-redirection-url-prefix=http://localhost:48459/redirect\?url=([^&]*).*', 'http://localhost:48459/get-redirect', '--desktop_file_hint=/usr/share/applications/webbrowser-app.desktop']
09:51:09.658 INFO _launcher:544 - waiting for process to exit.
09:51:09.660 INFO _launcher:567 - Killing process 5488
09:51:10.124 ERROR testresult:44 - ERROR: webapp_container.tests.test_redirection_pattern.WebappContainerRedirectionPatternTestCase.test_browse_to_redirection_pattern_url
09:51:10.125 ERROR testresult:44 - /var/log/syslog: {{{
}}}
09:51:10.126 ERROR testresult:44 - process-stderr (/usr/bin/webapp-container): {{{
/usr/bin/webapp-container: invalid option -- 't'
/usr/bin/webapp-container: invalid option -- 'e'
/usr/bin/webapp-container: invalid option -- 's'
/usr/bin/webapp-container: invalid option -- 't'
/usr/bin/webapp-container: invalid option -- 'a'
/usr/bin/webapp-container: invalid option -- 'b'
/usr/bin/webapp-container: invalid option -- 'i'
/usr/bin/webapp-container: invalid option -- 'l'
/usr/bin/webapp-container: invalid option -- 'i'
/usr/bin/webapp-container: invalid option -- 't'
/usr/bin/webapp-container: invalid option -- 'y'
/usr/bin/webapp-container: unrecognized option '--popup-redirection-url-prefix=http://localhost:48459/redirect?url=([^&]*).*'
Testability driver loaded. Wire protocol version is "1.4".
Invalid webapps installation
Invalid webapps installation
Using Oxide as the web engine backend
Empty path in webapps model search path update request
QQmlExpression: Expression file:///usr/share/webbrowser-app/webcontainer/WebApp.qml:171:25 depends on non-NOTIFYable properties:
unity::action::qml::ActionManager::globalContext
Empty pat...

review: Needs Fixing

[lp:~abreu-alexandre/webbrowser-app/fix-container-ap-tests]

783. By Alexandre Abreu on 2014-11-05

Account for the flackiness due to the asynchronously loaded oxide webview

[Alexandre Abreu (abreu-alexandre)]

updated

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:783
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1241/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6491
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4306
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/440
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/440
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/440/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/440
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6078
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7743
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7743/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15491
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3657
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4700
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4700/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1241/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

Looks good, thanks.

review: Approve

=== modified file 'tests/autopilot/webapp_container/tests/__init__.py'
--- tests/autopilot/webapp_container/tests/__init__.py	2014-11-03 18:43:48 +0000
+++ tests/autopilot/webapp_container/tests/__init__.py	2014-11-05 18:43:29 +0000
@@ -41,7 +41,7 @@
 
 class WebappContainerTestCaseBase(AutopilotTestCase):
     def setUp(self):
-        self.pointing_device = toolkit_emulators.get_pointing_device()
+        self.pointing_device = uitk.get_pointing_device()
         super(WebappContainerTestCaseBase, self).setUp()
 
     def get_webcontainer_app_path(self):
@@ -84,7 +84,7 @@
     def get_oxide_webview(self):
         container = self.get_webview().select_single(
             objectName='containerWebviewLoader')
-        return container.select_single('WebViewImplOxide')
+        return container.wait_select_single('WebViewImplOxide')
 
     def assert_page_eventually_loaded(self, url):
         webview = self.get_oxide_webview()