webbrowser-app

Merge lp:~abreu-alexandre/webbrowser-app/ebay-override into lp:webbrowser-app

  1. ebay-override
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp:~abreu-alexandre/webbrowser-app/ebay-override
Merge into: lp:webbrowser-app
Diff against target: 19 lines (+2/-0)
2 files modified
src/Ubuntu/Web/ua-overrides-desktop.js.in (+1/-0)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+1/-0)
To merge this branch: bzr merge lp:~abreu-alexandre/webbrowser-app/ebay-override
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+303264@code.launchpad.net

Commit message

Add Ebay override

Description of the change

Add Ebay override

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1519
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/601/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1242/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1242
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1113
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1113
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1113
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1100/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1100/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1100/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1100/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1100/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1100/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1100/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1100
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1100/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1100/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/601/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

The @CHROMIUM_VERSION@ tokens need to be updated to ${CHROMIUM_VERSION} because of recent changes in trunk.

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

And this doesn’t take into account all internatial ebay domains (e.g. ebay.co.uk, ebay.fr, ebay.in, …). I’ve fixed this here: https://bazaar.launchpad.net/~osomon/webbrowser-app/1656310-ua-override-gplus/revision/1588.

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

Already fixed in a different branch.

review: Disapprove

Unmerged revisions

1519. By Alexandre Abreu

Ebay overrides

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Web/ua-overrides-desktop.js.in'
2--- src/Ubuntu/Web/ua-overrides-desktop.js.in 2016-06-13 14:39:00 +0000
3+++ src/Ubuntu/Web/ua-overrides-desktop.js.in 2016-08-18 13:38:01 +0000
4@@ -29,4 +29,5 @@
5 ["^https?:\/\/hangouts\.google\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Safari/537.36"],
6 ["^https?:\/\/talkgadget\.google\.com\/hangouts\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Safari/537.36"],
7 ["^https?:\/\/plus\.google\.com\/hangouts\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Safari/537.36"],
8+ ["^https?:\/\/www\.ebay\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Safari/537.36"],
9 ];
10
11=== modified file 'src/Ubuntu/Web/ua-overrides-mobile.js.in'
12--- src/Ubuntu/Web/ua-overrides-mobile.js.in 2016-06-17 19:29:40 +0000
13+++ src/Ubuntu/Web/ua-overrides-mobile.js.in 2016-08-18 13:38:01 +0000
14@@ -30,4 +30,5 @@
15 ["^https?:\/\/hangouts\.google\.com\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4;) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Mobile Safari/537.36"],
16 ["^https?:\/\/talkgadget\.google\.com\/hangouts\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4;) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Mobile Safari/537.36"],
17 ["^https?:\/\/plus\.google\.com\/hangouts\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4;) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Mobile Safari/537.36"],
18+ ["^https?:\/\/www\.ebay\.com\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4;) AppleWebKit/537.36 Chrome/@CHROMIUM_VERSION@ Mobile Safari/537.36"],
19 ];

Subscribers

People subscribed via source and target branches

to status/vote changes: