Merge lp:~abreu-alexandre/webbrowser-app/desktop-download into lp:webbrowser-app
- desktop-download
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Olivier Tilloy |
Approved revision: | 1036 |
Merged at revision: | 1055 |
Proposed branch: | lp:~abreu-alexandre/webbrowser-app/desktop-download |
Merge into: | lp:webbrowser-app |
Diff against target: |
12 lines (+3/-0) 1 file modified
src/app/WebViewImpl.qml (+3/-0) |
To merge this branch: | bzr merge lp:~abreu-alexandre/webbrowser-app/desktop-download |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Handle desktop download by forwarding to the default browser
Description of the change
Handle desktop download by forwarding to the default browser
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Olivier Tilloy (osomon) wrote : | # |
The (downloadLoader
if (downloadLoader
[existing code]
} else {
}
The change otherwise looks good to me (but I haven’t tested it yet).
- 898. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 899. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 900. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 901. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 902. By Timo Jyrinki
-
No-change rebuild against Qt 5.4.0.
- 903. By Olivier Tilloy
-
Honour Window.close() requests.
This is for the browser app only, not for the webapp container. Fixes: #1353453
- 904. By Olivier Tilloy
-
Work around autopilot test failure by ensuring that the selection is cleared before clicking on the action button. Fixes: #1417118
Approved by: Riccardo Padovani - 905. By Olivier Tilloy
-
Add a config option to allow users to turn off automatic session restore.
To turn off session restore, add the following line to ~/.config/
webbrowser- app/settings. conf : restoreSession = false Fixes: #1366530
Approved by: Michael Zanetti - 906. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150217. 1-0ubuntu1 - 907. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 908. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 909. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 910. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 911. By Olivier Tilloy
-
Fix a flaky autopilot test. Fixes: #1423115
Approved by: Alexandre Abreu - 912. By Riccardo Padovani
-
Fixed design of multiselection in history view Fixes: #1412732
Approved by: Olivier Tilloy - 913. By Olivier Tilloy
-
Use Qt::AA_
ShareOpenGLCont exts when building with Qt >= 5.4. Fixes: #1387537 - 914. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150224- 0ubuntu1 - 915. By Robert Bruce Park
-
Launchpad automatic translations update.
- 916. By Olivier Tilloy
-
Use the new Item::grabToImage() API (new in Qt 5.4) to replace the custom ItemCapture element. Fixes: #1401581, #1425550
- 917. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150226. 1-0ubuntu1 - 918. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 919. By Olivier Tilloy
-
Update translation template.
- 920. By Olivier Tilloy
-
Specify the cache path on the web context, to avoid caching data under ~/.local/share/. Fixes: #1424726
- 921. By Olivier Tilloy
-
Remove all references to private Qt headers, now that we require Qt 5.4.
- 922. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150227- 0ubuntu1 - 923. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 924. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 925. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 926. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 927. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 928. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 929. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 930. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 931. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 932. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 933. By Olivier Tilloy
-
Update an autopilot test to click on the drawer button to dismiss the drawer.
With the upcoming changes to the text selection in the UITK, clicking on the address bar might accidentally grab a text selection handle, thus not dismissing the drawer menu. Clicking on the drawer button again should be more robust. - 934. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150316- 0ubuntu1 - 935. By Olivier Tilloy
-
On mobile, reveal the tabs view with a swipe gesture from the bottom edge.
Note: this re-adds qtbase5-private-dev and qtdeclarative5-
private- dev as build dependencies, required to build the code imported from unity8. This code will eventually go away, and the dependencies on private headers with it. Fixes: #1329943
Approved by: Ken VanDine, Florian Boucault - 936. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150320. 2-0ubuntu1 - 937. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 938. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 939. By Olivier Tilloy
-
Update translation template.
- 940. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 941. By Olivier Tilloy
-
Update the 'selection' test page to hopefully fix the failing autopilot test on mako. Fixes: #1433020, #1434193
- 942. By Olivier Tilloy
-
Discard selection when navigating away. Fixes: #1433503
- 943. By Olivier Tilloy
-
Remove workaround for bug #1377198, which was fixed in oxide 1.5.
- 944. By Olivier Tilloy
-
Use the loadEvent signal (introduced in oxide 1.3).
- 945. By Olivier Tilloy
-
Expose the SearchEngine type to QML.
- 946. By Olivier Tilloy
-
Rename test helper function from clear_cache() to clear_datadir(), to better reflect what it really does.
- 947. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150323- 0ubuntu1 - 948. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 949. By Olivier Tilloy
-
Use the new locationBarCont
roller API available in oxide 1.5 to control the position of the chrome. Fixes: #1365179, #1429132
Approved by: Alexandre Abreu - 950. By Olivier Tilloy
-
Rewrite URLs with an uppercase scheme. Fixes: #1436312
- 951. By Olivier Tilloy
-
Remove two broken symlinks.
- 952. By Olivier Tilloy
-
Always initialize member attribute at construction time.
Not really an issue here, but flagged by coverity (https:/
/scan.coverity. com/projects/ 4565), and easy enough to address. - 953. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150331. 2-0ubuntu1 - 954. By CI Train Bot Account
-
Resync trunk.
- 955. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 956. By Riccardo Padovani
-
Add settings page, per design specification. This adds qml-module-
qt-labs- folderlistmodel and qml-module- qt-labs- settings as runtime dependencies for webbrowser-app. Fixes: #1351183
Approved by: Bill Filler, Olivier Tilloy - 957. By Olivier Tilloy
-
Autopilot tests for the settings UI.
- 958. By Olivier Tilloy
-
Add a "Clear Cache" entry under the privacy settings. Fixes: #1260014, #1296364
Approved by: PS Jenkins bot - 959. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150408- 0ubuntu1 - 960. By Olivier Tilloy
-
Update translation template.
- 961. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 962. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 963. By Alexandre Abreu
-
remove qtwebkit deps (LP: #1362640) Fixes: #1362640
Approved by: Timo Jyrinki, PS Jenkins bot, Olivier Tilloy - 964. By Justin McPherson <justin@phablet-dev>
-
Command line options for media-hub use through Oxide.
Approved by: PS Jenkins bot - 965. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150410- 0ubuntu1 - 966. By CI Train Bot Account
-
Resync trunk.
- 967. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 968. By Arthur Mello
-
Add model support to control which history entries will be displayed based on a blacklist database
Approved by: PS Jenkins bot, Olivier Tilloy - 969. By Arthur Mello
-
Make Top Sites format equal to Bookmarks on the New Tab view
Approved by: PS Jenkins bot - 970. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150416- 0ubuntu1 - 971. By CI Train Bot Account
-
Resync trunk.
- 972. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 973. By Ugo Riboni
-
Include bookmark results in the suggestions list Fixes: #1351177
Approved by: Olivier Tilloy, PS Jenkins bot - 974. By Alexandre Abreu
-
Add missing reload button from the webapp container as specified in the design document.
Approved by: Olivier Tilloy, PS Jenkins bot - 975. By Ken VanDine
-
added ShareLink to contextualActions
Approved by: Olivier Tilloy, PS Jenkins bot
- 976. By Olivier Tilloy
-
Save the updated homepage when pressing return. Fixes: #1441874
Approved by: PS Jenkins bot, Riccardo Padovani - 977. By Leo Arias
-
In the autopilot tests, removed the extra focus step to write a URL. Fixes: #1441551
Approved by: Olivier Tilloy, PS Jenkins bot - 978. By Olivier Tilloy
-
Always exit fullscreen mode when the application becomes inactive. Fixes: #1331475
Approved by: PS Jenkins bot, Bill Filler - 979. By Olivier Tilloy
-
Recognize about:blank as a valid URL. Fixes: #1444139
Approved by: PS Jenkins bot - 980. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150422. 1-0ubuntu1 - 981. By CI Train Bot Account
-
Resync trunk.
- 982. By Olivier Tilloy
-
Update translation template.
- 983. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 984. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 985. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 986. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 987. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 988. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 989. By Alexandre Abreu
-
Add multi-window support for webapps Fixes: #1411722
Approved by: Olivier Tilloy - 990. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150430. 1-0ubuntu1 - 991. By CI Train Bot Account
-
Resync trunk.
- 992. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 993. By Leo Arias
-
Fixed flake8 error. Fixes: #1444170
Approved by: Olivier Tilloy - 994. By Olivier Tilloy
-
Run autopilot tests in a temporary profile directory, to avoid polluting the current user’s profile. Fixes: #1448838
- 995. By Arthur Mello
-
Change asset for the bottom edge hint.
Add text with open tabs count.
Approved by: Olivier Tilloy - 996. By Olivier Tilloy
-
Save the session periodically to mitigate the situation where multiple new tabs had been created when the browser crashes. Fixes: #1449761
- 997. By Olivier Tilloy
-
Visual feedback for pressed state of chrome buttons and drawer menu entries. Fixes: #1448336
- 998. By Olivier Tilloy
-
Remove deprecated compatibility code.
Approved by: David Barth - 999. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150506- 0ubuntu1 - 1000. By CI Train Bot Account
-
Resync trunk.
- 1001. By Olivier Tilloy
-
Update translation template.
- 1002. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1003. By Riccardo Padovani
-
Add support for data: URIs in the address bar, and remove length limitation for TLDs. Fixes: #1377953, #1441281, #1450154
Approved by: Olivier Tilloy - 1004. By Leo Arias
-
Fix the base class used when launching the app in autopilot tests.
Approved by: Olivier Tilloy, Christopher Lee - 1005. By Olivier Tilloy
-
Also set XDG_CONFIG_HOME (needed for tests not to override user-defined settings).
- 1006. By Ugo Riboni
-
Add suggestions from search engines in the suggestions list. Fixes: #1351151
Approved by: Olivier Tilloy - 1007. By Olivier Tilloy
-
Use the new Oxide APIs to better control visibility of the chrome.
This bumps the runtime dependency on liboxideqt-qmlplugin to 1.7. Fixes: #1441064, #1453908
Approved by: Alexandre Abreu - 1008. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150512- 0ubuntu1 - 1009. By CI Train Bot Account
-
Resync trunk.
- 1010. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1011. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1012. By Olivier Tilloy
-
Look for custom search engines description files in several locations.
This adds a build dependency on qml-module-qt-labs- folderlistmodel , to run unit tests at package construction time. Fixes: #1455207 - 1013. By Olivier Tilloy
-
Delay showing the fullscreen hint to prevent it from jumping up while the webview is being resized. Fixes: #1454097
Approved by: Ugo Riboni - 1014. By Olivier Tilloy
-
Use checkboxes instead of switches for verb phrases, per design guidance. Fixes: #1442851
Approved by: Riccardo Padovani - 1015. By Olivier Tilloy
-
Change the homepage in tests so that the domain name doesn’t contain a dot, to work around https:/
/launchpad. net/bugs/ 1108742. - 1016. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150515- 0ubuntu1 - 1017. By CI Train Bot Account
-
Resync trunk.
- 1018. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1019. By Olivier Tilloy
-
Make use of the WebContext.
maxCacheSizeHin t property, introduced in Oxide 1.6.
This bumps the dependency of qtdeclarative5-ubuntu- web-plugin on liboxideqt- qmlplugin to 1.6. Fixes: #1277659
Approved by: Alexandre Abreu - 1020. By Olivier Tilloy
-
Ensure the search engine delegates do not overlap with the settings header. Fixes: #1455399
Approved by: Riccardo Padovani - 1021. By Olivier Tilloy
-
When opening a new blank tab, always clear the address bar. Fixes: #1456199
Approved by: Arthur Mello - 1022. By Arthur Mello
-
Implement private browsing mode per design specification. Fixes: #1351179, #1457925, #1457958
Approved by: Olivier Tilloy - 1023. By Olivier Tilloy
-
Add Qwant to the default list of search engines.
- 1024. By Olivier Tilloy
-
Add missing import statement. Fixes: #1457060
Approved by: Alexandre Abreu - 1025. By Olivier Tilloy
-
Remove a number of useless calls to QTest::qWait() in unit tests, thus making them significantly faster to run.
- 1026. By Olivier Tilloy
-
Fix a flaky autopilot test.
On a mobile device with network access, the URL (http://en.wikipedia. org/wiki/ Linux) might be rewritten to https:/ /en.m.wikipedia .org/wiki/ Linux, thus making the test racy depending on when the check on the webview’s URL is performed. Fixes: #1456885 - 1027. By Olivier Tilloy
-
Delay hiding the tab contents to give it an opportunity to grab an up-to-date capture.
Improve the tab switching animation to not flicker and jump around that much. Fixes: #1452998 - 1028. By CI Train Bot Account
-
Releasing 0.23+15.
04.20150522. 1-0ubuntu1 - 1029. By Olivier Tilloy
-
Update translation template.
- 1030. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1031. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1032. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1033. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1034. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1035. By Launchpad Translations on behalf of phablet-team
-
Launchpad automatic translations update.
- 1036. By Alexandre Abreu
-
update
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Alexandre Abreu (abreu-alexandre) wrote : | # |
Updated
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1036
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Olivier Tilloy (osomon) wrote : | # |
Testing on desktop with gmail (in the browser app), and I’m still seeing the following message in the console:
[0601/112739:
However the download is correctly dispatched to my default browser, so the bug is fixed indeed. The above message is misleading though.
Preview Diff
1 | === modified file 'src/app/WebViewImpl.qml' |
2 | --- src/app/WebViewImpl.qml 2014-12-12 09:48:34 +0000 |
3 | +++ src/app/WebViewImpl.qml 2015-05-29 14:37:26 +0000 |
4 | @@ -60,6 +60,9 @@ |
5 | } |
6 | headers["User-Agent"] = webview.context.userAgent |
7 | downloadLoader.item.downloadMimeType(request.url, request.mimeType, headers, request.suggestedFilename) |
8 | + } else { |
9 | + // Desktop form factor case |
10 | + Qt.openUrlExternally(request.url) |
11 | } |
12 | } |
13 |
FAILED: Continuous integration, rev:898 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 1464/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1280 jenkins. qa.ubuntu. com/job/ generic- mediumtests- vivid/595 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 222 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 222 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 222/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 222 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1132 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1278 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1278/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 17944 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-vivid/ 486 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 705 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 705/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 1464/rebuild
http://