Merge lp:~abreu-alexandre/webapps-applications/add-backward-compatibility-code into lp:~webapps/webapps-applications/2.4

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 497
Merged at revision: 497
Proposed branch: lp:~abreu-alexandre/webapps-applications/add-backward-compatibility-code
Merge into: lp:~webapps/webapps-applications/2.4
Diff against target: 46 lines (+27/-1)
2 files modified
common/utils.js.in (+26/-0)
configure.ac (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/webapps-applications/add-backward-compatibility-code
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+147751@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/utils.js.in'
2--- common/utils.js.in 2012-12-07 12:56:24 +0000
3+++ common/utils.js.in 2013-02-11 19:51:27 +0000
4@@ -15,6 +15,32 @@
5 return strid;
6 }
7
8+/**
9+ * WARNING: this is only kept here for backward compatibility reasons.
10+ * This needs to be as soon as the individual scripts are SRUed and
11+ * updated to use the latest mechanism
12+ */
13+var _previousIndicators = [];
14+function showIndicators(list) {
15+ if (list.length == _previousIndicators.length) {
16+ var same = true;
17+ for (var i = 0; i < list.length; i++) {
18+ if (list[i].name != _previousIndicators[i].name)
19+ same = false;
20+ if (list[i].count != _previousIndicators[i].count)
21+ same = false;
22+ }
23+ if (same)
24+ return;
25+ }
26+ _previousIndicators = list;
27+ Unity.MessagingIndicator.clearIndicators();
28+ for (var i = 0; i < list.length; i++) {
29+ Unity.MessagingIndicator.showIndicator(list[i].name, { count: list[i].count,
30+ callback: list[i].callback });
31+ }
32+}
33+
34 function trim(str) {
35 return str.replace(/^\s+|\s+$/g, "");
36 }
37
38=== modified file 'configure.ac'
39--- configure.ac 2013-02-04 15:13:54 +0000
40+++ configure.ac 2013-02-11 19:51:27 +0000
41@@ -1,4 +1,4 @@
42-AC_INIT(webapps,2.4.12)
43+AC_INIT(webapps,2.4.13)
44
45 AC_SUBST([PACKAGE_NAME], ["$PACKAGE_NAME"])
46 AC_SUBST([PACKAGE_VERSION], ["$PACKAGE_VERSION"])

Subscribers

People subscribed via source and target branches

to all changes: