Merge lp:~abreu-alexandre/v8-cpp/handle-enum-class-to-v8-convert into lp:v8-cpp

[Alexandre Abreu]

Handle "enum class" as a type for to_v8 conversions.

Handle "enum class" as a type for to_v8 conversions. As is the Convert template struct that handles the from_v8 and to_v8 bits for integral types (used for v8::Number -> int conversion) is statically declared as having one to_v8 non parametric polymorph function, which does not work when called for non scoped enums (that do convert to int) and scoped enums (that dont),

[Marcus Tomlinson (marcustomlinson)]

Excellent! Thanks!

review: Approve

=== modified file 'src/internal/convert.h'
--- src/internal/convert.h	2015-10-19 13:20:40 +0000
+++ src/internal/convert.h	2016-01-11 17:21:51 +0000
@@ -156,7 +156,8 @@
         }
     }
 
-    static ToType to_v8(v8::Isolate* isolate, T value)
+    template <typename O>
+    static ToType to_v8(v8::Isolate* isolate, O value)
     {
         if (bits <= 32)
         {

=== modified file 'tests/functions/module.cpp'
--- tests/functions/module.cpp	2015-10-16 17:01:43 +0000
+++ tests/functions/module.cpp	2016-01-11 17:21:51 +0000
@@ -37,7 +37,8 @@
             .set_constructor<Local<Function>>()
             .add_method("get_shared", &TestCaller::get_shared)
             .add_method("call_me_with_shared", &TestCaller::call_me_with_shared)
-            .add_method("call_me", &TestCaller::call_me);
+            .add_method("call_me", &TestCaller::call_me)
+            .add_method("return_enum_function", &TestCaller::return_enum_function);
 
     // Prepare Shared binding
     v8cpp::Class<Shared> shared(isolate);

=== modified file 'tests/functions/test.cpp'
--- tests/functions/test.cpp	2015-10-16 17:01:43 +0000
+++ tests/functions/test.cpp	2016-01-11 17:21:51 +0000
@@ -109,3 +109,15 @@
     EXPECT_FLOAT_EQ(result4.count("3"), 1);
     EXPECT_FLOAT_EQ(result4.count("0"), 1);
 }
+
+TEST(Test, call_return_enum)
+{
+    auto result = v8cpp::run_script<TestCaller::TestEnum>(
+    R"(
+        var module = require("./test-functions-module");
+        var tc = new module.TestCaller(function() {});
+        tc.return_enum_function();
+    )");
+
+    EXPECT_EQ(result, TestCaller::TestEnum::ONE);
+}

=== modified file 'tests/functions/test.h'
--- tests/functions/test.h	2015-10-16 17:01:43 +0000
+++ tests/functions/test.h	2016-01-11 17:21:51 +0000
@@ -34,11 +34,24 @@
 class TestCaller
 {
 public:
+    enum class TestEnum
+    {
+        ZERO,
+        ONE,
+        TWO,
+        THREE
+    };
+
     explicit TestCaller(v8::Local<v8::Function> const& cb)
         : cb_(v8::Isolate::GetCurrent(), cb)
     {
     }
 
+    TestEnum return_enum_function() const
+    {
+      return TestEnum::ONE;
+    }
+
     std::string call_me() const
     {
         v8::Local<v8::Function> cb = v8cpp::to_local<v8::Function>(v8::Isolate::GetCurrent(), cb_);