unity-webapps-qml

Merge lp:~abreu-alexandre/unity-webapps-qml/encore-webapp-name-base64 into lp:unity-webapps-qml

  1. encore-webapp-name-base64
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 47
Merged at revision: 48
Proposed branch: lp:~abreu-alexandre/unity-webapps-qml/encore-webapp-name-base64
Merge into: lp:unity-webapps-qml
Diff against target: 12 lines (+1/-1)
1 file modified
src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-webapps-qml/encore-webapp-name-base64
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+182519@code.launchpad.net

Commit message

Encode webapp name in base64

Description of the change

Encode webapp name in base64

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/36/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-saucy-amd64-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-saucy-armhf-ci/36

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-qml-ci/36/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Simple enough!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp'
2--- src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp 2013-08-27 21:28:30 +0000
3+++ src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp 2013-08-27 23:23:17 +0000
4@@ -287,7 +287,7 @@
5 .arg(webappName)
6 .arg(iconName)
7 .arg(appId)
8- .arg(QString(QUrl::toPercentEncoding(webappName)));
9+ .arg(QString(webappName.toUtf8().toBase64().data()));
10
11 QFile f(desktopFilePath);
12 if ( ! f.open(QIODevice::WriteOnly))

Subscribers

People subscribed via source and target branches

to all changes: