Merge lp:~abreu-alexandre/unity-webapps-qml/backportoxide-1404 into lp:unity-webapps-qml/14.04

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 114
Merged at revision: 114
Proposed branch: lp:~abreu-alexandre/unity-webapps-qml/backportoxide-1404
Merge into: lp:unity-webapps-qml/14.04
Diff against target: 101 lines (+17/-9)
5 files modified
debian/control (+1/-3)
src/Ubuntu/UnityWebApps/UnityWebApps.js (+1/-2)
src/Ubuntu/UnityWebApps/UnityWebApps.qml (+9/-0)
src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+5/-3)
src/Ubuntu/UnityWebApps/common/js/unity-backend-messaging-proxy.js (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-webapps-qml/backportoxide-1404
Reviewer Review Type Date Requested Status
WebApps Pending
Review via email: mp+243288@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-04-30 01:13:30 +0000
3+++ debian/control 2014-12-01 14:06:58 +0000
4@@ -8,7 +8,6 @@
5 libnotify-dev,
6 # depend on oxide so that we don't build for archs that we can't install on
7 liboxideqtcore0,
8- libqt5webkit5-dev,
9 libunity-action-qt1-dev,
10 libunity-dev,
11 pkg-config,
12@@ -28,8 +27,7 @@
13
14 Package: unity-webapps-qml
15 Architecture: any
16-Depends: libqt5webkit5-qmlwebkitplugin,
17- liboxideqt-qmlplugin (>= 1.0),
18+Depends: liboxideqt-qmlplugin (>= 1.3.4),
19 qtdeclarative5-qtquick2-plugin,
20 qtdeclarative5-unity-action-plugin,
21 qtdeclarative5-ubuntu-ui-toolkit-plugin | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles,
22
23=== modified file 'src/Ubuntu/UnityWebApps/UnityWebApps.js'
24--- src/Ubuntu/UnityWebApps/UnityWebApps.js 2014-03-18 18:52:11 +0000
25+++ src/Ubuntu/UnityWebApps/UnityWebApps.js 2014-12-01 14:06:58 +0000
26@@ -66,8 +66,7 @@
27 var cb = this._onMessageReceivedCallback.bind(self);
28 self._bindeeProxies.messageReceivedConnect(cb);
29
30- cb = this._onLoadingStartedCallback.bind(self);
31- self._bindeeProxies.loadingStartedConnect(cb);
32+ this._onLoadingStartedCallback();
33 },
34
35 /**
36
37=== modified file 'src/Ubuntu/UnityWebApps/UnityWebApps.qml'
38--- src/Ubuntu/UnityWebApps/UnityWebApps.qml 2014-03-26 15:52:46 +0000
39+++ src/Ubuntu/UnityWebApps/UnityWebApps.qml 2014-12-01 14:06:58 +0000
40@@ -134,6 +134,13 @@
41 */
42 property var actionsContext: null
43
44+ /*!
45+ \qmlsignal UnityWebApps::userScriptsInjected()
46+
47+ This signal is emitted when the component has completed its initialization and
48+ the userscripts have been injected into the binded webview.
49+ */
50+ signal userScriptsInjected()
51
52 /*!
53 \qmlproperty string UnityWebApps::_opt_backendProxies
54@@ -210,6 +217,8 @@
55
56 internal.backends = backends;
57 internal.instance = instance;
58+
59+ userScriptsInjected();
60 }
61
62 /*!
63
64=== modified file 'src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js'
65--- src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-04-02 18:16:34 +0000
66+++ src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-12-01 14:06:58 +0000
67@@ -62,7 +62,7 @@
68 this.webview = webview;
69 this.disposer = disposer;
70 this.makeSignalDisconnecter = makeSignalDisconnecter;
71- this._WEBAPPS_USER_SCRIPT_CONTEXT = "oxide://UnityWebappsApi";
72+ this._WEBAPPS_USER_SCRIPT_CONTEXT = "oxide://main-world";
73 }
74 OxideWebviewAdapter.prototype = {
75 injectUserScripts: function(userScriptUrls) {
76@@ -72,8 +72,10 @@
77 var scriptStart = "import com.canonical.Oxide 1.0 as Oxide; Oxide.UserScript { context:";
78 var scriptEnd = "}";
79 var statement = scriptStart +
80- '"' + this._WEBAPPS_USER_SCRIPT_CONTEXT + '"' +
81- '; matchAllFrames: false; url: "' + userScriptUrls[i] + '";' + scriptEnd;
82+ '"' + this._WEBAPPS_USER_SCRIPT_CONTEXT
83+ + '"'
84+ + '; matchAllFrames: false; emulateGreasemonkey: true; url: "'
85+ + userScriptUrls[i] + '";' + scriptEnd;
86 context.addUserScript(Qt.createQmlObject(statement, this.webview));
87 }
88 },
89
90=== modified file 'src/Ubuntu/UnityWebApps/common/js/unity-backend-messaging-proxy.js'
91--- src/Ubuntu/UnityWebApps/common/js/unity-backend-messaging-proxy.js 2014-03-28 13:21:47 +0000
92+++ src/Ubuntu/UnityWebApps/common/js/unity-backend-messaging-proxy.js 2014-12-01 14:06:58 +0000
93@@ -4,7 +4,7 @@
94 navigator.qt.postMessage) {
95 return new UnityQtWebkitBackendMessagingProxy();
96 }
97- else if (window.oxide) {
98+ else if (oxide) {
99 return new UnityOxideBackendMessagingProxy();
100 }
101 return null;

Subscribers

People subscribed via source and target branches

to all changes: