Merge lp:~abreu-alexandre/unity-webapps-googleplus/update-manifest-with-url-redirect-pattern into lp:unity-webapps-googleplus

Proposed by Alexandre Abreu
Status: Merged
Merged at revision: 61
Proposed branch: lp:~abreu-alexandre/unity-webapps-googleplus/update-manifest-with-url-redirect-pattern
Merge into: lp:unity-webapps-googleplus
Diff against target: 6 lines (+1/-1)
1 file modified
manifest.json (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-webapps-googleplus/update-manifest-with-url-redirect-pattern
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
David Barth (community) Approve
Review via email: mp+216225@code.launchpad.net

Commit message

Update the URL patterns to handle the url redirection pattern that G+ uses.

Description of the change

Update the URL patterns to handle the url redirection pattern that G+ uses. This is still considered as navigating *inside* g+ otherwise if we open this outside right away, the redirection loop will complete and the user is left w/ a "you are navigating outside of google" page

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Barth (dbarth) :
review: Approve
62. By Alexandre Abreu

fix typo

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'manifest.json'
2--- manifest.json 2014-04-08 20:56:52 +0000
3+++ manifest.json 2014-04-22 16:49:13 +0000
4@@ -1,1 +1,1 @@
5-{"includes":["https://plus.google.com/*", "https://accounts.google.*/*", "https://www.google.*/a/*"],"requires":["utils.js","google-common.js"],"name":"GooglePlus","domain": "plus.google.com", "scripts":["GooglePlus.user.js"],"maintainer":"Webapps Team <webapps@lists.launchpad.net>","license":"GPL-3","manifest-version":"1.0","integration-version":"2.4.12","package-name":"GooglePlus","description":"Unity Webapp for GooglePlus", "homepage":"https://plus.google.com/","icons":{"128":"128/unity-webapps-google-plus.png","48":"48/unity-webapps-google-plus.png","52":"52/unity-webapps-google-plus.png","64":"64/unity-webapps-google-plus.png"}}
6+{"includes":["http://plus.google.com/*", "https://plus.google.com/*", "http://plus.url.google.com/*", "https://plus.url.google.com/*", "https://accounts.google.*/*", "https://www.google.*/a/*"],"requires":["utils.js","google-common.js"],"name":"GooglePlus","domain": "plus.google.com", "scripts":["GooglePlus.user.js"],"maintainer":"Webapps Team <webapps@lists.launchpad.net>","license":"GPL-3","manifest-version":"1.0","integration-version":"2.4.12","package-name":"GooglePlus","description":"Unity Webapp for GooglePlus", "homepage":"https://plus.google.com/","icons":{"128":"128/unity-webapps-google-plus.png","48":"48/unity-webapps-google-plus.png","52":"52/unity-webapps-google-plus.png","64":"64/unity-webapps-google-plus.png"}}

Subscribers

People subscribed via source and target branches

to all changes: