Merge lp:~abreu-alexandre/unity-js-scopes/not-handled-activation-query-default into lp:unity-js-scopes

Proposed by Alexandre Abreu on 2016-03-03
Status: Merged
Approved by: Marcus Tomlinson on 2016-03-04
Approved revision: 137
Merged at revision: 138
Proposed branch: lp:~abreu-alexandre/unity-js-scopes/not-handled-activation-query-default
Merge into: lp:unity-js-scopes
Diff against target: 12 lines (+1/-1)
1 file modified
src/bindings/src/scope-base.cc (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-js-scopes/not-handled-activation-query-default
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) 2016-03-03 Approve on 2016-03-04
PS Jenkins bot (community) continuous-integration Needs Fixing on 2016-03-03
Review via email: mp+288032@code.launchpad.net

Commit message

Return default ActivationQueryBase (not handled) if no callback is found

Description of the change

Return default ActivationQueryBase (not handled) if no callback is found

To post a comment you must log in.
Marcus Tomlinson (marcustomlinson) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bindings/src/scope-base.cc'
2--- src/bindings/src/scope-base.cc 2016-02-13 16:01:06 +0000
3+++ src/bindings/src/scope-base.cc 2016-03-03 22:01:45 +0000
4@@ -145,7 +145,7 @@
5 unity::scopes::Result const &result,
6 unity::scopes::ActionMetadata const &metadata) {
7 if (activate_callback_.IsEmpty()) {
8- return nullptr;
9+ return unity::scopes::ScopeBase::activate(result, metadata);
10 }
11
12 return EventQueue::instance().run<unity::scopes::ActivationQueryBase::UPtr>(

Subscribers

People subscribed via source and target branches

to all changes: