Merge lp:~abreu-alexandre/ubuntu-html5-theme/tweak-too-small-size-html-container into lp:ubuntu-html5-theme

Proposed by Alexandre Abreu
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 125
Merged at revision: 125
Proposed branch: lp:~abreu-alexandre/ubuntu-html5-theme/tweak-too-small-size-html-container
Merge into: lp:ubuntu-html5-theme
Diff against target: 15 lines (+3/-2)
1 file modified
src/ubuntu-html5-app-launcher/main.qml (+3/-2)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-html5-theme/tweak-too-small-size-html-container
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Adnane Belmadiaf Approve
Review via email: mp+205150@code.launchpad.net

Commit message

small tweak of the basic size for the container

Description of the change

small tweak of the basic size for the container

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

LGTM

review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

thanks! absolutely units.gu is the right way to do it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu-html5-app-launcher/main.qml'
2--- src/ubuntu-html5-app-launcher/main.qml 2014-01-27 18:42:31 +0000
3+++ src/ubuntu-html5-app-launcher/main.qml 2014-02-06 12:56:09 +0000
4@@ -18,8 +18,9 @@
5
6 import QtQuick 2.0
7 import Ubuntu.WebApps 0.1
8+import Ubuntu.Components 0.1
9
10 WebAppContainer {
11- height: 400
12- width: 400
13+ width: units.gu(100)
14+ height: units.gu(75)
15 }

Subscribers

People subscribed via source and target branches