Merge lp:~abreu-alexandre/ubuntu-html5-theme/fix-any-architecture into lp:ubuntu-html5-theme

Proposed by Alexandre Abreu
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 105
Merged at revision: 103
Proposed branch: lp:~abreu-alexandre/ubuntu-html5-theme/fix-any-architecture
Merge into: lp:ubuntu-html5-theme
Diff against target: 33 lines (+4/-3)
2 files modified
debian/control (+3/-2)
debian/ubuntu-html5-theme-examples.install (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-html5-theme/fix-any-architecture
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu HTML5 Theme Developers Pending
Review via email: mp+202128@code.launchpad.net

Commit message

Fix all architecture to any in the debian/control

Description of the change

Fix all architecture to any in the debian/control

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

when I build this branch I see lintian errors:
E: ubuntu-html5-theme source: not-binnmuable-any-depends-all ubuntu-html5-container -> ubuntu-html5-theme
E: ubuntu-html5-container: missing-dependency-on-libc needed by usr/bin/ubuntu-html5-app-launcher

The second one can be "fixed" like as described hereL http://lintian.debian.org/tags/missing-dependency-on-libc.html

Revision history for this message
Daniel Holbach (dholbach) wrote :

'all' packages normally don't contain any architecture-specific code. Because it doesn't matter we build 'all' packages on i386 because that's where we used to have the most and fastest builders... I think. If we have arch-specific code we need to use 'any'.

104. By Alexandre Abreu

update debian/control deps

105. By Alexandre Abreu

update debian/control deps

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

updated

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Lintian errors resolved, built successfully for me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-12-06 14:30:37 +0000
3+++ debian/control 2014-01-20 15:47:38 +0000
4@@ -60,8 +60,9 @@
5 for Ubuntu. This package contains autopilot tests for it.
6
7 Package: ubuntu-html5-container
8-Architecture: all
9+Architecture: any
10 Depends: ${misc:Depends},
11+ ${shlibs:Depends},
12 ${python:Depends},
13 dpkg-dev,
14 libqt5webkit5-qmlwebkitplugin,
15@@ -69,7 +70,7 @@
16 qtdeclarative5-qtquick2-plugin,
17 qtdeclarative5-ubuntu-ui-extras-browser-plugin,
18 qmlscene,
19- ubuntu-html5-theme (= ${binary:Version}),
20+ ubuntu-html5-theme (= ${source:Version}),
21 Description: Ubuntu HTML5 QML container component for HTML5 touch apps.
22 This package contains the Ubuntu HTML5 QML component used to embed HTML5
23 apps at runtime.
24
25=== modified file 'debian/ubuntu-html5-theme-examples.install'
26--- debian/ubuntu-html5-theme-examples.install 2013-11-27 16:33:23 +0000
27+++ debian/ubuntu-html5-theme-examples.install 2014-01-20 15:47:38 +0000
28@@ -1,3 +1,3 @@
29 examples/html5-theme/* usr/share/ubuntu-html5-theme/0.1/examples
30 examples/html5-theme/ubuntu-html5-ui-gallery.desktop usr/share/applications
31-examples/container/* usr/share/ubuntu-html5-container/examples
32\ No newline at end of file
33+examples/container/* usr/share/ubuntu-html5-container/examples

Subscribers

People subscribed via source and target branches