Merge lp:~abreu-alexandre/platform-api/add-opterror-to-getopt-long into lp:platform-api

Proposed by Alexandre Abreu
Status: Approved
Approved by: Iain Lane
Approved revision: 309
Proposed branch: lp:~abreu-alexandre/platform-api/add-opterror-to-getopt-long
Merge into: lp:platform-api
Diff against target: 12 lines (+2/-0)
1 file modified
src/ubuntu/application/common/mirclient/application_options_mir.cpp (+2/-0)
To merge this branch: bzr merge lp:~abreu-alexandre/platform-api/add-opterror-to-getopt-long
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+195077@code.launchpad.net

Commit message

Remove the 'invalid option' message automatically triggered when getopt_long encounters an unknown option. The error message can be misleading since it is being triggered out of nowhere for any app being launched w/ specific options & for options like '-testability'

Description of the change

Remove the 'invalid option' message automatically triggered when getopt_long encounters an unknown option. The error message can be misleading since it is being triggered out of nowhere for any app being launched w/ specific options & for options like '-testability'

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
172. By kevin gunn

mir server abi break, bump build dep to 0.1.1

173. By PS Jenkins bot

Releasing 0.19+14.04.20131119.1-0ubuntu1 (revision 172 from lp:platform-api).

Approved by PS Jenkins bot.

174. By kevin gunn

update mir deb build dep to ver 0.1.2

175. By PS Jenkins bot

Releasing 0.19+14.04.20131128.1-0ubuntu1 (revision 174 from lp:platform-api).

Approved by PS Jenkins bot.

176. By Martin Pitt

Fix all compiler warnings.

Approved by Ricardo Mendoza, PS Jenkins bot.

177. By Alexandros Frantzis

mirclient: Initialize MirSurfaceParameters::output_id field.

Approved by Robert Carr, PS Jenkins bot.

Revision history for this message
Iain Lane (laney) wrote :

I had to add this at src/ubuntu/mircommon/application_options_mir.cpp:101 for the messages to go away.

review: Needs Fixing
178. By Gerry Boland

Fix FTBFS with Mir12 change - mir::geometry::PixelFormat was removed, using MirPixelFormat instead. Fixes: https://bugs.launchpad.net/bugs/1266674.

Approved by Timo Jyrinki, PS Jenkins bot.

179. By Timo Jyrinki

bump debian version dependency for mir to 0.1.3 to force rebuild

180. By Ricardo Mendoza

Add function to specify initial window geometry before creation.

Approved by PS Jenkins bot, Gerry Boland.

181. By PS Jenkins bot

Releasing 0.19+14.04.20140108.1-0ubuntu1 (revision 179 from lp:platform-api).

Approved by PS Jenkins bot.

182. By Martin Pitt

Add backend for simulated sensor data.

Approved by Ricardo Mendoza, PS Jenkins bot, Thomas Voß.

183. By Albert Astals Cid

Build fixes and typos.

Approved by Gerry Boland, PS Jenkins bot.

184. By PS Jenkins bot

Releasing 0.20+14.04.20140114.1-0ubuntu1 (revision 183 from lp:platform-api).

Approved by PS Jenkins bot.

185. By Thomas Voß

Adopt to changes in dbus-cpp and location-service.

186. By Łukasz Zemczak

Bump the dbus-cpp dependency to 1.0.0

187. By PS Jenkins bot

Releasing 0.20+14.04.20140204-0ubuntu1

188. By kevin gunn

bump debian version for mir to 0.1.4

189. By Ricardo Salveti

Making android code compatible with 4.4.

190. By PS Jenkins bot

Releasing 0.20+14.04.20140204.1-0ubuntu1

191. By Martin Pitt

Fix crash in ua_sensors_*_new() if there is no available backend. Return NULL instead. Fixes: 1272294

192. By PS Jenkins bot

Releasing 0.20+14.04.20140211-0ubuntu1

193. By kevin gunn

bump dep on mir0.1.5

194. By PS Jenkins bot

Releasing 0.20+14.04.20140212-0ubuntu1

195. By Daniel d'Andrada

Clipboard implementation using UnityService through the mir socket

196. By PS Jenkins bot

Releasing 0.20+14.04.20140214-0ubuntu1

197. By Thomas Voß

Remove obsolete assert on bridge as failures are captured higher up in the stack now.

198. By PS Jenkins bot

Releasing 0.20+14.04.20140221-0ubuntu1

199. By Łukasz Zemczak

Bump the build-dependency on dbus-cpp due to the ABI change

200. By PS Jenkins bot

Releasing 0.20+14.04.20140307-0ubuntu1

201. By kevin gunn

bump debian dep to mir0.1.6

202. By PS Jenkins bot

Releasing 0.20+14.04.20140310.1-0ubuntu1

203. By kevin gunn

bump to mir0.1.7

204. By PS Jenkins bot

Releasing 0.20+14.04.20140317.1-0ubuntu1

205. By Chris Gagnon

enable getting coverage in CI

206. By PS Jenkins bot

Releasing 0.20+14.04.20140401-0ubuntu1

207. By Andreas Pokorny

CMakeLists adaptation to make platform-api cross compile with a simple chroot setup.

Note that <PKG_NAME>_LINK_LIBRARIES variables were removed from link_directories and respective
<PKG_NAME>_LDFLAGS variables were instead put into target_link_libraries. Those informations
attached to targets are transitively forwarded to the user of the library. link_directories
only attaches the information to the source directory.

208. By PS Jenkins bot

Releasing 0.20+14.04.20140407-0ubuntu1

209. By Alan Griffiths

Changes for compatibility with Mir 0.1.8

210. By Gerry Boland

Manually call mir's SurfacePlacementStrategy::place and SessionListener::surface_created methods for in process client Surface

Mir 0.1.8 refactoring causes in-process client surfaces to be an implementation detail of Mir's surface stack, and prevents shell from getting access to its surface to position it and define input areas on it. To fix this,we perform the following:
  1. Create an InProcessClientSession to represent the in-process client
  2. Get access to Mir's SurfacePlacementStrategy object and call its place method explicitly, to allow shell to position its surface
  3. Get access to Mir's SessionListener object and call its surface_created method explicitly, to notify shell its surface was created

211. By PS Jenkins bot

Releasing 0.20+14.04.20140411-0ubuntu1

212. By Alberto Aguirre

needed for mir019

213. By PS Jenkins bot

Releasing 0.20+14.10.20140430.1-0ubuntu1

214. By Thomas Voß

Adjust the sensors API to get rid of passing float/double values over the Ubuntu/Android process boundary.
Switch compilation of the Ubuntu side to GCC 4.8.

215. By PS Jenkins bot

Releasing 0.21+14.10.20140507-0ubuntu1

216. By Gerry Boland

Merge devel breanch at commit 213 - consists of commit "Add ua_ui_window_get_size()."

217. By PS Jenkins bot

Releasing 1.1.0+14.10.20140515.1-0ubuntu1

218. By Thomas Voß

Add hw alarm api implementation for android's /dev/alarm.
Add simple test executable for hw alarm api implementation on android.
Adjust interface signatures to make sure that status of operations is reported correctly.
Add HW Alarms API interface definition.
Add Ubuntu implementation that will bridge over to the android world. Fixes: 1299916

219. By Manuel de la Peña

Add missing agps hooks so that we can use SUPL server to have faster gps location.

220. By PS Jenkins bot

Update symbols

221. By PS Jenkins bot

Releasing 1.2.0+14.10.20140522.1-0ubuntu1

222. By Cemil Azizoglu

staging 0.2.0

223. By PS Jenkins bot

Releasing 1.2.0+14.10.20140605-0ubuntu1

224. By Ricardo Mendoza

Ver2 Platform-API

* Structure changes
* Dynamic backend loading
* Flexible testing providers

225. By PS Jenkins bot

Update symbols

226. By PS Jenkins bot

Releasing 2.0.0+14.10.20140612-0ubuntu1

227. By Tarmac

Updated for Mir 0.3.0 release.

228. By PS Jenkins bot

Releasing 2.0.0+14.10.20140618.1-0ubuntu1

229. By Ricardo Mendoza

Orientation Sensor

230. By PS Jenkins bot

Update symbols

231. By PS Jenkins bot

Releasing 2.1.0+14.10.20140623.1-0ubuntu1

232. By Ricardo Mendoza

Add missing enable/disable functions for haptic

233. By PS Jenkins bot

Releasing 2.1.0+14.10.20140624.4-0ubuntu1

234. By Thomas Voß

Adjust to API changes in location service.
Implement controller interface.
Add functions to query the accuracy estimates for a position update. Fixes: 1281817

235. By PS Jenkins bot

Update symbols

236. By PS Jenkins bot

Releasing 2.1.0+14.10.20140630-0ubuntu1

237. By Ricardo Mendoza

Run thread for dbus client connection (sensors service)

238. By Sergio Schvezov

Setting -Wl,--no-as-needed for sensors.

239. By PS Jenkins bot

Releasing 2.1.0+14.10.20140701-0ubuntu1

240. By kevin gunn

Bump Mir dependencies to 0.4.0.

241. By PS Jenkins bot

Releasing 2.1.0+14.10.20140702-0ubuntu1

242. By Timo Jyrinki

New rebuild forced

243. By Cemil Azizoglu

Mir display server 0.5.0 release.
Approved by: kevin gunn

244. By PS Jenkins bot

Releasing 2.1.0+14.10.20140717-0ubuntu1

245. By Thomas Voß

Explicitly select g++-4.9 to prevent from ABI breaks.

246. By PS Jenkins bot

Releasing 2.1.0+14.10.20140721-0ubuntu1

247. By Gerry Boland

Add window resize & focus handling. Involves renaming "input event" to just "event"

A window resize event is not an "input event", hence the rename

Needed for QtCompositor. By Daniel d'Andrada
Approved by: Robert Carr, PS Jenkins bot, Ricardo Mendoza

248. By PS Jenkins bot

Replaced 0replaceme with real versions.

249. By PS Jenkins bot

Releasing 2.2.0+14.10.20140728-0ubuntu1

250. By Thomas Voß

Check for null in functions accessing a session object.
  Make sure that exceptions cannot propagate for controller interactions. Fixes: 1338610, 1347928
Approved by: Charles Kerr, PS Jenkins bot

251. By PS Jenkins bot

Releasing 2.2.0+14.10.20140730-0ubuntu1

252. By Ricardo Mendoza

Remove stale event.h header, use public one instead.
Approved by: Ricardo Salveti, PS Jenkins bot

253. By PS Jenkins bot

Releasing 2.2.0+14.10.20140801-0ubuntu1

254. By Thomas Voß

Implement installation of changed handlers.
Subscribe to state properties. Fixes: 1348334
Approved by: PS Jenkins bot

255. By PS Jenkins bot

Releasing 2.2.0+14.10.20140808-0ubuntu1

256. By Alan Griffiths

Bump ABI for Mir 0.6.0 release.
Approved by: Cemil Azizoglu

257. By PS Jenkins bot

Releasing 2.2.0+14.10.20140812-0ubuntu1

258. By Iain Lane

Fix error by pulling out and sharing a struct instead of defining it twice. Fixes: 1350874
Approved by: PS Jenkins bot, Thomas Voß

259. By PS Jenkins bot

Releasing 2.2.0+14.10.20140821-0ubuntu1

260. By Thomas Voß

Implement installation of changed handlers.
Subscribe to state properties. Fixes: 1348334
Approved by: Pete Woods, PS Jenkins bot

261. By PS Jenkins bot

Releasing 2.2.0+14.10.20140825-0ubuntu1

262. By Cemil Azizoglu

Rebuild for the Mir 0.7.0 release.

263. By PS Jenkins bot

Releasing 2.2.0+14.10.20140829-0ubuntu1

264. By Thomas Voß

Add functions reporting error state when attempting to connect to the location service.
Approved by: Ricardo Salveti, PS Jenkins bot

265. By PS Jenkins bot

Releasing 2.3.0+14.10.20140916.3-0ubuntu1

266. By Gerry Boland

Add readonly notifyable property "orientation" to Window Fixes: 1288332
Approved by: Daniel d'Andrada, PS Jenkins bot

267. By PS Jenkins bot

Replaced 0replaceme with real versions.

268. By PS Jenkins bot

Releasing 2.4.0+14.10.20140922.1-0ubuntu1

269. By Alberto Aguirre

Fix memory leak on sensor event notifications (LP: #1206146) Fixes: 1206146
Approved by: PS Jenkins bot, Thomas Voß

270. By PS Jenkins bot

Releasing 2.4.0+14.10.20140926-0ubuntu1

271. By Gerry Boland

For for exposeOrientation breaking hybris side
Approved by: Ricardo Salveti, PS Jenkins bot, Kevin DuBois

272. By PS Jenkins bot

Releasing 2.4.0+14.10.20140929-0ubuntu1

273. By Robert Carr

Support requesting the restored state as a way to leave fullscreen. Fixes: 1194550, 1328839
Approved by: Gerry Boland, PS Jenkins bot, Daniel d'Andrada

274. By PS Jenkins bot

Replaced 0replaceme with real versions.

275. By PS Jenkins bot

Releasing 2.5.0+14.10.20141001.3-0ubuntu1

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

updated

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
276. By Cemil Azizoglu

Rebuild for Mir 0.8.0.
Approved by: PS Jenkins bot

277. By PS Jenkins bot

Releasing 2.5.0+14.10.20141010-0ubuntu1

278. By Daniel d'Andrada

Remove clipboard implementation

- Using Mir custom messages as the RPC method is bad because
  it's not possible for the server to send a message/signal to the
  client. We need this to tell a client when the global clipboard
  contents have changed. Besides there's currently a bug in mir
  custom messages that hasn't been dealt with.

- The clipboard API is bad. See comments in clipboard.h
Approved by: Robert Carr, PS Jenkins bot

279. By PS Jenkins bot

Releasing 2.5.0+14.10.20141013-0ubuntu1

280. By Ricardo Salveti

alarm: using the right type for the alarm type when setting up the hw alarm Fixes: 1376125
Approved by: PS Jenkins bot, Thomas Voß, Ricardo Mendoza

281. By PS Jenkins bot

Releasing 2.5.0+14.10.20141015-0ubuntu1

282. By Alexandros Frantzis

Remove unused Mir private header include (LP: #1381333) Fixes: 1381333
Approved by: Kevin DuBois, Cemil Azizoglu, PS Jenkins bot, Daniel van Vugt

283. By PS Jenkins bot

Releasing 2.5.0+15.04.20141027-0ubuntu1

284. By Alberto Aguirre

No-change rebuild against mir 0.9.0
Approved by: Cemil Azizoglu, PS Jenkins bot

285. By PS Jenkins bot

Releasing 2.5.0+15.04.20141124-0ubuntu1

286. By Alberto Aguirre

Stub out mirserver backend
Approved by: Gerry Boland, PS Jenkins bot

287. By PS Jenkins bot

Releasing 2.6.0+15.04.20141126-0ubuntu1

288. By Ricardo Mendoza

* Allow for module-override of specific providers of the Platform API
* Implement support for named pipe event reader on sensors test plugin

Approved by: Jim Hodapp, Daniel d'Andrada, PS Jenkins bot

289. By CI Train Bot Account

Releasing 2.7.0+15.04.20150123-0ubuntu1

290. By You-Sheng Yang

* Check array boundary for KeyedVector
Approved by: Ricardo Salveti

291. By CI Train Bot Account

Releasing 2.7.0+15.04.20150128-0ubuntu1

292. By Ricardo Mendoza

Do not load the test backend unless a specific override list is provided. Also, add the test backend as dependency of the main module, now that it is directly usable without other modules.
Approved by: PS Jenkins bot

293. By CI Train Bot Account

Releasing 2.8.0+15.04.20150203-0ubuntu1

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
294. By Ricardo Mendoza

Dont abort on soft errors, instead fall back to dummy provider if possible.
Approved by: PS Jenkins bot

295. By CI Train Bot Account

Releasing 2.8.1+15.04.20150306-0ubuntu1

296. By Robert Carr

Expose MirConnection form UApplicationIntance and deprecate the ua_ui namespace.
Approved by: Alberto Aguirre, PS Jenkins bot, Gerry Boland

297. By CI Train Bot Account

Releasing 2.9.0+15.04.20150318-0ubuntu1

298. By Michał Sawicz

Fix u_application_instance_get_mir_connection symbol version Fixes: #1433936
Approved by: PS Jenkins bot

299. By Ricardo Mendoza

Disable building the Android backends we no longer use.
Approved by: PS Jenkins bot

300. By CI Train Bot Account

Releasing 2.9.0+15.04.20150320-0ubuntu1

301. By Loïc Minier

Fix dependency on transitional package; should fix multi-arch installation of
armhf package on an amd64 system.
Approved by: Ricardo Mendoza

302. By CI Train Bot Account

Releasing 2.9.0+15.04.20150326-0ubuntu1

303. By Alberto Aguirre

Delete deprecated mir functions.

Why now? https://code.launchpad.net/~mir-team/mir/privatize-event/+merge/254149

The old mir-event is being made private and the new event does not have many fields corresponding to legacy in the UbuntuEvent (i.e. "is_system_key"). Thus it seems like rather than update unused code (qtubuntu is already ported) to build but be broken its a good time to delete it all.

Update major version to 3.
Approved by: PS Jenkins bot, Ricardo Mendoza, Gerry Boland, Alberto Aguirre

304. By Alberto Aguirre

Remove the unused mirserver component
Approved by: PS Jenkins bot, Robert Carr

305. By Steve Langasek

Fix pkg-config to declare the dependency on mirclient headers. Fixes: #1465958
Approved by: Alberto Aguirre

306. By CI Train Bot Account

Releasing 3.0.0+15.10.20150706-0ubuntu1

307. By Alexandre Abreu

Remove the 'invalid option' message automatically triggered when getopt_long encounters an unknown option. The error message can be misleading since it is being triggered out of nowhere for any app being launched w/ specific options & for options like '-testability'

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
308. By Alexandre Abreu

Forgotten header

309. By Alexandre Abreu

Forgotten header

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Updated to trunk & tested on mako/r247

Revision history for this message
Iain Lane (laney) wrote :

this is a sense making change!

review: Approve

Unmerged revisions

309. By Alexandre Abreu

Forgotten header

308. By Alexandre Abreu

Forgotten header

307. By Alexandre Abreu

Remove the 'invalid option' message automatically triggered when getopt_long encounters an unknown option. The error message can be misleading since it is being triggered out of nowhere for any app being launched w/ specific options & for options like '-testability'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/application/common/mirclient/application_options_mir.cpp'
2--- src/ubuntu/application/common/mirclient/application_options_mir.cpp 2015-06-18 00:36:42 +0000
3+++ src/ubuntu/application/common/mirclient/application_options_mir.cpp 2015-07-10 16:59:37 +0000
4@@ -112,6 +112,8 @@
5 }
6 }
7
8+ opterr = 0;
9+
10 while(true)
11 {
12 int option_index = 0;

Subscribers

People subscribed via source and target branches