Merge lp:~abreu-alexandre/oxide/v8-deprecations into lp:~oxide-developers/oxide/oxide.trunk

Proposed by Alexandre Abreu on 2016-02-10
Status: Merged
Merged at revision: 1471
Proposed branch: lp:~abreu-alexandre/oxide/v8-deprecations
Merge into: lp:~oxide-developers/oxide/oxide.trunk
Diff against target: 141 lines (+27/-17)
7 files modified
shared/renderer/oxide_script_message_handler_renderer.cc (+5/-4)
shared/renderer/oxide_script_message_manager.cc (+1/-1)
shared/renderer/oxide_script_message_request_impl_renderer.cc (+1/-1)
shared/renderer/oxide_script_referenced_object.cc (+16/-7)
shared/renderer/oxide_script_referenced_object.h (+1/-1)
shared/renderer/oxide_user_script_slave.cc (+1/-1)
shared/renderer/oxide_v8_scoped_persistent.h (+2/-2)
To merge this branch: bzr merge lp:~abreu-alexandre/oxide/v8-deprecations
Reviewer Review Type Date Requested Status
Chris Coulson 2016-02-10 Approve on 2016-05-10
Review via email: mp+285633@code.launchpad.net

Commit message

Fix v8::SetHiddenValue, v8::CallbackData & v8::TryCatch() deprecations

Description of the change

Fix v8::SetHiddenValue, v8::CallbackData & v8::TryCatch() deprecations

To post a comment you must log in.
1341. By Chris Coulson on 2016-02-11

Install CMake package config files in to the correct place

1342. By Chris Coulson on 2016-02-11

Make CMake package config files work correctly - OxideQtCoreConfig.cmake needs to export -rpath-link option for libffmpeg.so

1343. By Chris Coulson on 2016-02-11

Hopefully fix CMake 2.8 build

1344. By Chris Coulson on 2016-02-11

PYTHON needs to be defined in OxideCommonProperties.cmake now

1345. By Chris Coulson on 2016-02-15

Switch from DelegatedRendererLayer to SurfaceLayer in RenderWidgetHostView, as the former has been deleted from Chromium

1346. By Chris Coulson on 2016-02-15

Add an expliciy std::move when returning a scoped_ptr. It seems that current compilers figure this out, but older compilers don't

1347. By Chris Coulson on 2016-02-15

Depend on cc_surfaces

1348. By Chris Coulson on 2016-02-16

Merge r1107 from lp:oxide/crmaster

1349. By Chris Coulson on 2016-02-16

Increase timeout for tst_CustomURLSchemes.txt - it's a slow test anyway but it's hitting the timeout on my laptop now

1350. By Alexandre Abreu on 2016-02-17

Support vibration api

1351. By Alexandre Abreu on 2016-02-17

Update WebSecurityOrigin.h's location due to upstream reorg

1352. By Alexandre Abreu on 2016-02-18

Fix new media hub binding build issues due to upstream changes

1353. By Chris Coulson on 2016-02-20

Don't call in to RWHV on the compositor thread

1354. By Chris Coulson on 2016-02-22

Merge r1112 from lp:oxide/crmaster

1355. By Chris Coulson on 2016-02-22

Fix 32-bit builds

1356. By Chris Coulson on 2016-02-22

Fix a typo, else the checked_cast is useless

1357. By Chris Coulson on 2016-02-22

Fix component builds with vibration support

1358. By Olivier Tilloy on 2016-02-24

Override OxideQQuickWebView::touchUngrabEvent().

1359. By Chris Coulson on 2016-02-24

Ensure we package all of the libraries

1360. By Chris Coulson on 2016-02-24

Move compositing, input event and windowing event handling out of WebView

1361. By Chris Coulson on 2016-02-26

Switch to a single-threaded webview compositor

1362. By Chris Coulson on 2016-02-27

Merge -r1116 from lp:oxide/crmaster

1363. By Chris Coulson on 2016-02-27

Fix some test failures

1364. By Loïc Molinari on 2016-02-29

Add support for scale factor retrieved from the Ubuntu QPA plugin

1365. By Chris Coulson on 2016-03-01

Fix device scaling mess. This makes scaling work correctly with Qt platforms other than ubuntu

1366. By Chris Coulson on 2016-03-02

Always prefer EGLImage over texture sharing. Also, ensure we correctly blacklist share group usage when necessary - this seems to have regressed because of a Chromium change

1367. By Olivier Tilloy on 2016-03-03

Hardcode selection colors to match the current Ambiance theme from the Ubuntu UI Toolkit.

1368. By Chris Coulson on 2016-03-03

Add some compositor trace events

1369. By Chris Coulson on 2016-03-08

Merge r1122 from lp:oxide/crmaster

1370. By Chris Coulson on 2016-03-08

Bump Chromium rev to 42b754c (50.0.2661.11)

1371. By Chris Coulson on 2016-03-09

Don't asynchronously request GPU info at startup - it races with webview construction, resulting in crashes because we can get different results from subsequent calls to CompositorUtils::GetCompositingMode on GPU's where GPU compositing is blacklisted

1372. By Olivier Tilloy on 2016-03-10

Reset the touch selection state when the RenderWidgetHostView changes.

1373. By Alexandre Abreu on 2016-03-11

Remove chromedriver build since to avoid issues with conflicting resources, upstreams chromedriver works

1374. By Chris Coulson on 2016-03-11

Make net::CookieStore access single threaded

1375. By Chris Coulson on 2016-03-11

Bump Chromium rev to 2c28ebf (50.0.2661.26)

1376. By Chris Coulson on 2016-03-11

Bump qt version to 1.15.0

1377. By Chris Coulson on 2016-03-15

Convert QTouchEvent directly to ui::MotionEvent.

Omitting ui::TouchEvent means we no longer have to round the touch coordinates, which should make scroll / pinch gestures smoother on high DPI screens

1378. By Chris Coulson on 2016-03-16

Fix crash in oxide::InputMethodContext::SetImeBridge

1379. By Alexandre Abreu on 2016-03-16

Fix media hub build following upstream prefixed EME removal

1380. By Chris Coulson on 2016-03-16

Clean up MotionEventFactory::UpdateTouchPoint a bit

1381. By Chris Coulson on 2016-03-16

Merge r1136 from lp:oxide/crmaster

1382. By Chris Coulson on 2016-03-16

Depend on //url/ipc to unbreak component builds

1383. By Chris Coulson on 2016-03-20

In fullscreen mode, the size of the view is based on the screen geometry rather than the actual view size to work around a Flash bug. In this case, we need to update the browser compositor size when the screen geometry changes

1384. By Chris Coulson on 2016-03-21

Rename some functions after 13afe03 landed upstream

1385. By Chris Coulson on 2016-03-21

Update for changes to WebMediaPlayerDelegate::Observer

1386. By Chris Coulson on 2016-03-21

#include media/base/timestamp_constants.h

1387. By Olivier Tilloy on 2016-03-21

Do not show the insertion handle on a tap for an empty editable text.
This aligns with upstream, and anticipates the removal of the config flag (crbug.com/554568).

1388. By Olivier Tilloy on 2016-03-21

Touch selection API updates:
 - enable adaptive handle orientation
 - add an 'handleDragInProgress' property to OxideQQuickTouchSelectionController
 - add a hide() method to OxideQQuickTouchSelectionController

1389. By Chris Coulson on 2016-03-22

Add CookieStoreUIProxy, which is an implementation of net::CookieStore that proxies calls from the UI thread to the real cookie store on the IO thread

1390. By Chris Coulson on 2016-03-24

LP: #1561450

1391. By Chris Coulson on 2016-03-27

Merge r1147 from lp:oxide/crmaster

1392. By Chris Coulson on 2016-03-28

Fix a shutdown abort in single-process mode

1393. By Chris Coulson on 2016-03-30

Unbreak document-start / document-end script injection

1394. By Chris Coulson on 2016-03-30

Some updates to the way tests run:
- runtests.py is now driven with a simple yaml config. This makes it easier to invoke tests manually for debugging.
- runtests.py makes it easy to run tests inside gdb
- All QML test sequences get their own test binary.
- The QML test runners now have a --file option for running a single test, which is useful for debugging.
- Various cleanups to the test support QML module.

1395. By Chris Coulson on 2016-03-30

Try to reduce test flakiness in tst_GeolocationPermissionRequest.qml - in test_GeolocationPermissionRequest5_subframe_delete_cancel, the RFH isn't always deleted before the test times out

1396. By Chris Coulson on 2016-03-31

Fix a test failure in tst_WebView_downloadRequested.qml

1397. By Chris Coulson on 2016-03-31

Merge r1153 from lp:oxide/crmaster

1398. By Chris Coulson on 2016-03-31

Fix flakiness in tst_bug1324909.qml

1399. By Chris Coulson on 2016-03-31

Pick up Chromium rev 73269de - "Ensure the suggested name for downloads gets passed to Oxide"

1400. By Chris Coulson on 2016-03-31

Make entire test cases skippable so that we can disable specific tests in certain environments (eg, single-process mode). This is achieved by adding SkippableTestCase (an implementation of TestCase) and exposing a (currently empty) TestProperties object to QML. Whilst this isn't adding support for driving tests with a manifest, it should be a sufficient solution for LP: #1399207

1401. By Chris Coulson on 2016-03-31

Re-organize the qml tests:
  - qml-ssl-test folds in to qml-api-test - these were only separate because we never used to run the former with HTTPS servers.
  - Add qml-web-platform-test for testing integration of web facing features.

1402. By Chris Coulson on 2016-03-31

Fix a test shutdown crash

1403. By Chris Coulson on 2016-04-01

Revert unintentional change

1404. By Chris Coulson on 2016-04-01

Have the test runner create and expose a TestWebContext for each test case. This will make it easier to introduce single process test sequences

1405. By Chris Coulson on 2016-04-02

Disable profiler timing - we don't have chrome://profiler/, and this is disabled by default on Chrome/Android too

1406. By Chris Coulson on 2016-04-02

Allow the first created WebContext to become the default context in single process mode

1407. By Chris Coulson on 2016-04-02

Add QML test sequences for single-process. Currently there are quite a few failures that will be fixed in follow-ups. In the meantime, you can skip the single-process tests by passing ARGS="-E single-process" to make test

1408. By Chris Coulson on 2016-04-04

Revert addition of SkippableTestCase - this doesn't work as expected. As we don't allow the test case to complete, it doesn't get removed from Qt.testResults (see testlogger.js) which causes the test sequence to hang later on. Fixing this will either require us to depend on the internals of TestCase (and still may not even behave how we want), or have a complete reimplementation of TestCase which isn't really worth the effort

1409. By Chris Coulson on 2016-04-04

Add the ability to exclude entire test cases by adding them to a simple text file

1410. By Chris Coulson on 2016-04-04

Exclude tst_Incognito_cleanup.qml and tst_Incognito_cookies.qml from single process tests

1411. By Chris Coulson on 2016-04-04

Fix test failure in tst_WebContext_doNotTrack.qml. Not particularly sure why this fails or is unique to single process, but the fix seems to work

1412. By Chris Coulson on 2016-04-04

Fix tst_WebContext_defaultVideoCaptureDevice.qml in single process

1413. By Chris Coulson on 2016-04-04

Exclude tst_WebContext_sessionCookies.qml in single process. This isn't testable without restarting the app

1414. By Chris Coulson on 2016-04-04

Exclude tst_WebContext_semi_construct_only_properties.qml from single-process tests

1415. By Chris Coulson on 2016-04-04

Hopefully fix flakiness in tst_WebView_closeRequested.qml

1416. By Chris Coulson on 2016-04-04

Drop tst_bug1349510 - this has failed for ages because it relies on navigating to a URL longer than url::kMaxURLChars, which causes the render process to abort. If this was still a real problem, we'd know about it by now

1417. By Chris Coulson on 2016-04-04

Fix component builds

1418. By Chris Coulson on 2016-04-08

Make tst_SecurityStatus.qml work in single process

1419. By Chris Coulson on 2016-04-08

Make WebContext only take ownership of WebContextDelegateWorker if it's unowned when it's first attached, rather than unconditionally taking ownership. This ensures they get cleaned up at the end of test cases. Prior to this, they leak in single process tests, causing subsequent test failures

1420. By Chris Coulson on 2016-04-08

Fix test failure in tst_WebContext_userAgentOverrides.qml

1421. By Chris Coulson on 2016-04-08

Ensure WebContext.popupBlockerEnabled is restored during test case cleanup

1422. By Chris Coulson on 2016-04-08

Hopefully fix tst_NetworkCallbackEvents.qml test flakiness

1423. By Chris Coulson on 2016-04-08

Ensure WebContext.userAgent is reset at the end of tests

1424. By Chris Coulson on 2016-04-08

Another case where WebContext.userAgent needs to be reset

1425. By Chris Coulson on 2016-04-08

Don't run tst_WebView_context.qml and tst_WebView_incognito.qml in single process

1426. By Chris Coulson on 2016-04-08

Fix tst_WebView_mixedContentOverrides.qml in single-process - ensure we reset the override settings on the main frame when a load commits that wasn't initiated from a reload

1427. By Chris Coulson on 2016-04-08

Fix tst_WebContext_userScripts.qml in single process

1428. By Chris Coulson on 2016-04-08

Drop the warning when changing the process model. At this point, single process works well enough to properly support now

1429. By Chris Coulson on 2016-04-09

Put shared/ and qt/core/ in to separate components

1430. By Chris Coulson on 2016-04-09

Add missing file

1431. By Chris Coulson on 2016-04-12

Hide surface_id from Compositor clients

1432. By Chris Coulson on 2016-04-12

Remove RendererFrameEvictor - it's redundant anyway because we destroy the webview compositor when it's hidden. Now we just drive eviction from the webview compositor. This removes a bogus dependency on GetFormFactorHint

1433. By Chris Coulson on 2016-04-13

Get rid of CompositorProxy and its implementation - this was only really required when we used a threaded compositor

1434. By Chris Coulson on 2016-04-13

Handle null callbacks in CookieStoreUIProxy

1435. By Chris Coulson on 2016-04-13

Merge r1169 from lp:oxide/crmaster

1436. By Chris Coulson on 2016-04-13

Bump Chromium rev to 638cb45 (51.0.2704.4)

1437. By Chris Coulson on 2016-04-13

Move GetGLES2Decoder in to Oxide

1438. By Chris Coulson on 2016-04-14

Revert r1433 for causing crashes

1439. By Chris Coulson on 2016-04-14

Extend test timeout again, as it still times out occasionally for me

1440. By Chris Coulson on 2016-04-14

Get rid of CompositorProxy and its implementation - this was only really required when we used a threaded compositor

1441. By Chris Coulson on 2016-04-14

Fix tst_NavigationRequest triggers renderer crash

1442. By Olivier Tilloy on 2016-04-14

Add a 'version' and a 'chromiumVersion' properties to the Oxide global object.

1443. By Chris Coulson on 2016-04-14

Depend on gles2_utils

1444. By Chris Coulson on 2016-04-14

Get rid of Compositor::IsActive

1445. By Olivier Tilloy on 2016-04-18

Add a WebView.zoomFactor property to the QML API.

1446. By Chris Coulson on 2016-04-18

Bump Chromium rev to da6ce57 (51.0.2704.7)

1447. By Chris Coulson on 2016-04-18

Expand testing capability - this adds 2 new test suites:
- API unit tests (qt/tests/unit). These are compiled unit tests for public APIs and are expected to be fairly limited in scope, and not require a full browser process.
- Internal unit tests. This will allow unit testing of internal classes that can be tested without requiring a full browser process.
I've not added many tests yet - future commits will expand on these.

There's still a hole in test capability - testing internal classes that require a full browser process. For these, I plan to add a test shell binary that will allow this.

1448. By Olivier Tilloy on 2016-04-18

Gracefully handle the case where glGetString(GL_SHADING_LANGUAGE_VERSION) returns a null pointer.

1449. By Chris Coulson on 2016-04-20

CertificateErrorDispatcherClient only has a single method, so just convert it in to a callback. In addition to that, add thorough unit tests for CertificateErrorDispatcher

1450. By Chris Coulson on 2016-04-20

Fix mistake in shared.gyp

1451. By Chris Coulson on 2016-04-20

Bump Chromium rev to 87b5ef8 (51.0.2704.19)

1452. By Chris Coulson on 2016-04-20

Switch from scoped_ptr to std::unique_ptr

1453. By Alexandre Abreu on 2016-04-22

Add support for device id constraint support in getusermedia

1454. By Chris Coulson on 2016-04-22

Move various files to shared/browser/ssl

1455. By Chris Coulson on 2016-04-22

When creating a new WebContents via CreateNewWindow, WebContentsView::RenderViewHostChanged is called before the associated RWHV is created which means we don't attach its surface layer to the webview compositor. Fix this by ensuring this happens when we create the RWHV

1456. By Chris Coulson on 2016-04-25

Provide a dummy message for BeforeUnloadDialog components for compatibility purposes

1457. By Chris Coulson on 2016-04-25

Bump qt version to 1.16.0

1458. By Chris Coulson on 2016-04-27

Ensure we resize / rescale the webview compositor viewport when the screen is updated

1459. By Chris Coulson on 2016-04-28

Merge r1188 from lp:oxide/crmaster

1460. By Olivier Tilloy on 2016-04-29

Internationalize the user-facing strings for the names of the cameras.

1461. By Olivier Tilloy on 2016-05-02

Fix FTBFS with media-hub enabled.

1462. By Chris Coulson on 2016-05-03

Scale the location bar height when the screen changes

1463. By Chris Coulson on 2016-05-04

Split SecurityStatus out of WebView, and add extensive unit tests for this code

1464. By Chris Coulson on 2016-05-04

Correctly namespace the exising unit tests, and also get the arguments to the EXPECT_* and ASSERT_* macros the correct way around

1465. By Chris Coulson on 2016-05-04

Update oxide_enum_flags.h with the code from Firefox

1466. By Chris Coulson on 2016-05-04

Add simple unit tests for SSLHostStateDelegate

1467. By Chris Coulson on 2016-05-10

Use the proper cmake variables for imported libraries rather than using the names directly

1468. By Chris Coulson on 2016-05-10

QOpenGLFunctions uses GLESv2 symbols inline in Qt builds that define QT_OPENGL_ES_2. Ensure libOxideQtQuick.so.0 links against libGLESv2 in this case

1469. By Chris Coulson on 2016-05-10

Add missing find_package(Qt5Gui)

1470. By Alexandre Abreu on 2016-05-10

Fix the name of the archive created by test-package - it's not bzip2 compressed

1471. By Alexandre Abreu on 2016-05-10

Fix v8::SetHiddenValue, v8::CallbackData & v8::TryCatch() deprecations

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shared/renderer/oxide_script_message_handler_renderer.cc'
2--- shared/renderer/oxide_script_message_handler_renderer.cc 2016-04-20 22:09:41 +0000
3+++ shared/renderer/oxide_script_message_handler_renderer.cc 2016-05-10 18:23:17 +0000
4@@ -46,10 +46,11 @@
5 bool ScriptMessageHandlerRenderer::ReceiveMessageCallback(
6 ScriptMessage* message,
7 std::unique_ptr<base::Value>* error_payload) {
8- v8::HandleScope handle_scope(manager_->isolate());
9+ v8::Isolate* isolate = manager_->isolate();
10+ v8::HandleScope handle_scope(isolate);
11 v8::Context::Scope context_scope(manager_->GetV8Context());
12
13- v8::Handle<v8::Function> function(callback_.NewHandle(manager_->isolate()));
14+ v8::Handle<v8::Function> function(callback_.NewHandle(isolate));
15
16 ScriptMessageImplRenderer* m =
17 static_cast<ScriptMessageImplRenderer *>(message);
18@@ -58,9 +59,9 @@
19 m->GetHandle()
20 };
21
22- v8::TryCatch try_catch;
23+ v8::TryCatch try_catch(isolate);
24 {
25- v8::MicrotasksScope microtasks(manager_->isolate(),
26+ v8::MicrotasksScope microtasks(isolate,
27 v8::MicrotasksScope::kDoNotRunMicrotasks);
28 manager_->frame()->GetWebFrame()->callFunctionEvenIfScriptDisabled(
29 function, manager_->GetV8Context()->Global(), arraysize(argv), argv);
30
31=== modified file 'shared/renderer/oxide_script_message_manager.cc'
32--- shared/renderer/oxide_script_message_manager.cc 2016-04-20 22:09:41 +0000
33+++ shared/renderer/oxide_script_message_manager.cc 2016-05-10 18:23:17 +0000
34@@ -124,7 +124,7 @@
35 v8::MicrotasksScope microstasks(isolate,
36 v8::MicrotasksScope::kDoNotRunMicrotasks);
37
38- v8::TryCatch try_catch;
39+ v8::TryCatch try_catch(isolate);
40 v8::Local<v8::Function> function(script->Run().As<v8::Function>());
41 if (try_catch.HasCaught()) {
42 LOG(ERROR) << "Caught exception when running script";
43
44=== modified file 'shared/renderer/oxide_script_message_request_impl_renderer.cc'
45--- shared/renderer/oxide_script_message_request_impl_renderer.cc 2016-04-20 22:09:41 +0000
46+++ shared/renderer/oxide_script_message_request_impl_renderer.cc 2016-05-10 18:23:17 +0000
47@@ -40,7 +40,7 @@
48 v8::Handle<v8::Function> function,
49 int argc,
50 v8::Local<v8::Value> argv[]) {
51- v8::TryCatch try_catch;
52+ v8::TryCatch try_catch(manager()->isolate());
53 {
54 v8::MicrotasksScope microtasks(manager()->isolate(),
55 v8::MicrotasksScope::kDoNotRunMicrotasks);
56
57=== modified file 'shared/renderer/oxide_script_referenced_object.cc'
58--- shared/renderer/oxide_script_referenced_object.cc 2015-01-16 22:46:17 +0000
59+++ shared/renderer/oxide_script_referenced_object.cc 2016-05-10 18:23:17 +0000
60@@ -39,9 +39,12 @@
61 data_.reset(isolate, v8::External::New(isolate, this));
62
63 if (!handle.IsEmpty()) {
64- handle->SetHiddenValue(
65- v8::String::NewFromUtf8(isolate, kWrappedNativeObject),
66- data_.NewHandle(isolate));
67+ handle->SetPrivate(
68+ manager_->GetV8Context(),
69+ v8::Private::ForApi(
70+ isolate,
71+ v8::String::NewFromUtf8(isolate, kWrappedNativeObject)),
72+ data_.NewHandle(isolate)).FromJust();
73 }
74 }
75
76@@ -60,14 +63,20 @@
77 v8::Isolate* isolate = v8::Isolate::GetCurrent();
78 v8::HandleScope handle_scope(isolate);
79
80- v8::Local<v8::Value> val(handle->GetHiddenValue(
81- v8::String::NewFromUtf8(isolate, kWrappedNativeObject)));
82- if (val.IsEmpty() || !val->IsExternal()) {
83+ v8::Local<v8::Value> value;
84+ handle->GetPrivate(
85+ isolate->GetCallingContext(),
86+ v8::Private::ForApi(
87+ isolate,
88+ v8::String::NewFromUtf8(isolate, kWrappedNativeObject)))
89+ .ToLocal(&value);
90+
91+ if (value.IsEmpty() || !value->IsExternal()) {
92 return nullptr;
93 }
94
95 return reinterpret_cast<ScriptReferencedObjectBase *>(
96- val.As<v8::External>()->Value());
97+ value.As<v8::External>()->Value());
98 }
99
100 } // namespace oxide
101
102=== modified file 'shared/renderer/oxide_script_referenced_object.h'
103--- shared/renderer/oxide_script_referenced_object.h 2016-01-04 13:40:25 +0000
104+++ shared/renderer/oxide_script_referenced_object.h 2016-05-10 18:23:17 +0000
105@@ -53,7 +53,7 @@
106 private:
107 template <class U>
108 static void NearDeathCallback(
109- const v8::WeakCallbackData<v8::Object, scoped_refptr<U> >& data) {
110+ const v8::WeakCallbackInfo<scoped_refptr<U> >& data) {
111 scoped_refptr<U>* refptr = data.GetParameter();
112 (*refptr)->handle_.reset();
113 delete refptr;
114
115=== modified file 'shared/renderer/oxide_user_script_slave.cc'
116--- shared/renderer/oxide_user_script_slave.cc 2016-04-20 22:09:41 +0000
117+++ shared/renderer/oxide_user_script_slave.cc 2016-05-10 18:23:17 +0000
118@@ -141,7 +141,7 @@
119
120 v8::Local<v8::Script> script(v8::Script::Compile(wrapped_src));
121
122- v8::TryCatch try_catch;
123+ v8::TryCatch try_catch(isolate);
124 {
125 v8::MicrotasksScope microtasks(isolate,
126 v8::MicrotasksScope::kDoNotRunMicrotasks);
127
128=== modified file 'shared/renderer/oxide_v8_scoped_persistent.h'
129--- shared/renderer/oxide_v8_scoped_persistent.h 2014-02-28 12:53:41 +0000
130+++ shared/renderer/oxide_v8_scoped_persistent.h 2016-05-10 18:23:17 +0000
131@@ -62,8 +62,8 @@
132
133 template <typename P>
134 void SetWeak(P* parameters,
135- typename v8::WeakCallbackData<T, P>::Callback callback) {
136- handle_.SetWeak(parameters, callback);
137+ typename v8::WeakCallbackInfo<P>::Callback callback) {
138+ handle_.SetWeak(parameters, callback, v8::WeakCallbackType::kParameter);
139 }
140
141 private:

Subscribers

People subscribed via source and target branches