Code review comment for lp:~abreu-alexandre/oxide/handle-noncommitted-navigation

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This isn't quite right - you should still call LoadSucceeded in this case, just with the status code set to 0. And the comment isn't accurate - the load is committed (it has to be, otherwise that's a bug), but initial renderer-initiated about:blank navigations don't get a navigation entry.

This also needs a test

review: Needs Fixing

« Back to merge proposal