Merge lp:~abreu-alexandre/oxide/handle-noncommitted-navigation into lp:~oxide-developers/oxide/oxide.trunk
Proposed by
Alexandre Abreu
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1169 | ||||
Proposed branch: | lp:~abreu-alexandre/oxide/handle-noncommitted-navigation | ||||
Merge into: | lp:~oxide-developers/oxide/oxide.trunk | ||||
Diff against target: |
72 lines (+51/-1) 3 files modified
qt/tests/qmltests/crash/tst_bug1477760.html (+6/-0) qt/tests/qmltests/crash/tst_bug1477760.qml (+41/-0) shared/browser/oxide_web_view.cc (+4/-1) |
||||
To merge this branch: | bzr merge lp:~abreu-alexandre/oxide/handle-noncommitted-navigation | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Coulson | Approve | ||
Review via email: mp+265865@code.launchpad.net |
Commit message
Some transient about:blank navigations are not committed so those do end up with no navigation entries whatsoever.
Description of the change
Some transient about:blank navigations are not committed so those do end up with no navigation entries whatsoever.
To post a comment you must log in.
This isn't quite right - you should still call LoadSucceeded in this case, just with the status code set to 0. And the comment isn't accurate - the load is committed (it has to be, otherwise that's a bug), but initial renderer-initiated about:blank navigations don't get a navigation entry.
This also needs a test