Merge lp:~abranson/rockwork/trunk into lp:rockwork

Proposed by Andrew Branson
Status: Merged
Merged at revision: 114
Proposed branch: lp:~abranson/rockwork/trunk
Merge into: lp:rockwork
Diff against target: 160 lines (+28/-12)
7 files modified
rockworkd/libpebble/blobdb.cpp (+6/-5)
rockworkd/libpebble/blobdb.h (+1/-5)
rockworkd/libpebble/notification.cpp (+11/-1)
rockworkd/libpebble/notification.h (+5/-0)
rockworkd/libpebble/platforminterface.h (+0/-1)
rockworkd/libpebble/timelineitem.cpp (+4/-0)
rockworkd/libpebble/timelineitem.h (+1/-0)
To merge this branch: bzr merge lp:~abranson/rockwork/trunk
Reviewer Review Type Date Requested Status
Michael Zanetti Pending
Review via email: mp+289487@code.launchpad.net

Description of the change

More changes to libpebble that shouldn't break RockWork. Removing orphan dependencies on Qt5Organizer, moving the UUID generation to the Notification constructor, and setting the correct parentId on Notifications. The latter should result in dismiss notifications calling back RockWork, but I don't think that will have any effect.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rockworkd/libpebble/blobdb.cpp'
2--- rockworkd/libpebble/blobdb.cpp 2016-02-27 22:39:19 +0000
3+++ rockworkd/libpebble/blobdb.cpp 2016-03-18 11:46:49 +0000
4@@ -4,7 +4,6 @@
5 #include "watchdatawriter.h"
6
7 #include <QDebug>
8-#include <QOrganizerRecurrenceRule>
9 #include <QDir>
10 #include <QSettings>
11
12@@ -110,10 +109,12 @@
13 iconId = TimelineAttribute::IconIDNotificationGeneric;
14 }
15
16- QUuid itemUuid = QUuid::createUuid();
17+ QUuid itemUuid = notification.uuid();
18 TimelineItem timelineItem(itemUuid, TimelineItem::TypeNotification);
19 timelineItem.setFlags(TimelineItem::FlagSingleEvent);
20
21+ timelineItem.setParentId(QUuid("ed429c16-f674-4220-95da-454f303f15e2"));
22+
23 TimelineAttribute titleAttribute(TimelineAttribute::TypeTitle, notification.sender().remove(QRegExp("<[^>]*>")).left(64).toUtf8());
24 timelineItem.appendAttribute(titleAttribute);
25
26@@ -153,7 +154,7 @@
27 m_notificationSources.insert(itemUuid, notification);
28 }
29
30-void BlobDB::insertTimelinePin(const QUuid &uuid, TimelineItem::Layout layout, bool isAllDay, const QDateTime &startTime, const QDateTime &endTime, const QString &title, const QString &desctiption, const QMap<QString, QString> fields, bool recurring)
31+void BlobDB::insertTimelinePin(const QUuid &uuid, TimelineItem::Layout layout, bool isAllDay, const QDateTime &startTime, const QDateTime &endTime, const QString &title, const QString &description, const QMap<QString, QString> fields, bool recurring)
32 {
33 // TimelineItem item(TimelineItem::TypePin, TimelineItem::FlagSingleEvent, QDateTime::currentDateTime().addMSecs(1000 * 60 * 2), 60);
34
35@@ -166,8 +167,8 @@
36 TimelineAttribute titleAttribute(TimelineAttribute::TypeTitle, title.toUtf8());
37 item.appendAttribute(titleAttribute);
38
39- if (!desctiption.isEmpty()) {
40- TimelineAttribute bodyAttribute(TimelineAttribute::TypeBody, desctiption.left(128).toUtf8());
41+ if (!description.isEmpty()) {
42+ TimelineAttribute bodyAttribute(TimelineAttribute::TypeBody, description.left(128).toUtf8());
43 item.appendAttribute(bodyAttribute);
44 }
45
46
47=== modified file 'rockworkd/libpebble/blobdb.h'
48--- rockworkd/libpebble/blobdb.h 2016-02-11 23:54:34 +0000
49+++ rockworkd/libpebble/blobdb.h 2016-03-18 11:46:49 +0000
50@@ -9,10 +9,6 @@
51
52 #include <QObject>
53 #include <QDateTime>
54-#include <QOrganizerEvent>
55-
56-QTORGANIZER_USE_NAMESPACE
57-
58
59 class BlobDB : public QObject
60 {
61@@ -42,7 +38,7 @@
62 explicit BlobDB(Pebble *pebble, WatchConnection *connection);
63
64 void insertNotification(const Notification &notification);
65- void insertTimelinePin(const QUuid &uuid, TimelineItem::Layout layout, bool isAllDay, const QDateTime &startTime, const QDateTime &endTime, const QString &title, const QString &desctiption, const QMap<QString, QString> fields, bool recurring);
66+ void insertTimelinePin(const QUuid &uuid, TimelineItem::Layout layout, bool isAllDay, const QDateTime &startTime, const QDateTime &endTime, const QString &title, const QString &description, const QMap<QString, QString> fields, bool recurring);
67 void removeTimelinePin(const QUuid &uuid);
68 void insertReminder();
69 void clearTimeline();
70
71=== modified file 'rockworkd/libpebble/notification.cpp'
72--- rockworkd/libpebble/notification.cpp 2015-12-11 22:22:51 +0000
73+++ rockworkd/libpebble/notification.cpp 2016-03-18 11:46:49 +0000
74@@ -3,7 +3,17 @@
75 Notification::Notification(const QString &sourceId) :
76 m_sourceId(sourceId)
77 {
78-
79+ m_uuid = QUuid::createUuid();
80+}
81+
82+QUuid Notification::uuid() const
83+{
84+ return m_uuid;
85+}
86+
87+void Notification::setUuid(QUuid uuid)
88+{
89+ m_uuid = uuid;
90 }
91
92 QString Notification::sourceId() const
93
94=== modified file 'rockworkd/libpebble/notification.h'
95--- rockworkd/libpebble/notification.h 2016-02-27 22:39:19 +0000
96+++ rockworkd/libpebble/notification.h 2016-03-18 11:46:49 +0000
97@@ -2,6 +2,7 @@
98 #define NOTIFICATION_H
99
100 #include <QString>
101+#include <QUuid>
102
103 class Notification
104 {
105@@ -26,6 +27,9 @@
106
107 Notification(const QString &sourceId = QString());
108
109+ QUuid uuid() const;
110+ void setUuid(const QUuid id);
111+
112 QString sourceId() const;
113 void setSourceId(const QString &sourceId);
114
115@@ -48,6 +52,7 @@
116 void setActToken(QString actToken);
117
118 private:
119+ QUuid m_uuid;
120 QString m_sourceId;
121 QString m_sourceName;
122 QString m_sender;
123
124=== modified file 'rockworkd/libpebble/platforminterface.h'
125--- rockworkd/libpebble/platforminterface.h 2015-12-21 03:46:24 +0000
126+++ rockworkd/libpebble/platforminterface.h 2016-03-18 11:46:49 +0000
127@@ -5,7 +5,6 @@
128 #include "libpebble/musicmetadata.h"
129
130 #include <QObject>
131-#include <QOrganizerItem>
132
133 class PlatformInterface: public QObject
134 {
135
136=== modified file 'rockworkd/libpebble/timelineitem.cpp'
137--- rockworkd/libpebble/timelineitem.cpp 2015-12-12 23:25:54 +0000
138+++ rockworkd/libpebble/timelineitem.cpp 2016-03-18 11:46:49 +0000
139@@ -22,6 +22,10 @@
140 return m_itemId;
141 }
142
143+void TimelineItem::setParentId(QUuid parentId) {
144+ m_parentId = parentId;
145+}
146+
147 void TimelineItem::setLayout(quint8 layout)
148 {
149 m_layout = layout;
150
151=== modified file 'rockworkd/libpebble/timelineitem.h'
152--- rockworkd/libpebble/timelineitem.h 2016-02-27 22:39:19 +0000
153+++ rockworkd/libpebble/timelineitem.h 2016-03-18 11:46:49 +0000
154@@ -246,6 +246,7 @@
155
156 QUuid itemId() const;
157
158+ void setParentId(QUuid parentId);
159 void setLayout(quint8 layout);
160 void setFlags(Flags flags);
161

Subscribers

People subscribed via source and target branches