Merge lp:~abone/ubuntu/precise/console-setup/fix-433897 into lp:ubuntu/precise/console-setup
| Status: | Merged |
|---|---|
| Merge reported by: | Colin Watson |
| Merged at revision: | not available |
| Proposed branch: | lp:~abone/ubuntu/precise/console-setup/fix-433897 |
| Merge into: | lp:ubuntu/precise/console-setup |
| Diff against target: |
69 lines (+39/-0) 4 files modified
debian/changelog (+10/-0) debian/console-setup.console-font.upstart (+12/-0) debian/console-setup.initramfs-confhook (+13/-0) debian/rules (+4/-0) |
| To merge this branch: | bzr merge lp:~abone/ubuntu/precise/console-setup/fix-433897 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson | 2012-09-28 | Needs Fixing on 2012-10-09 | |
| Ubuntu branches | 2012-08-09 | Pending | |
|
Review via email:
|
|||
Description of the Change
Branch have fixes for broken console fonts for non-latin languages. The issue is reproducible since Maverik (Natty, Oneiric and Precise are affected), but you must ensure cryptosetup package is not installed. It has initramfs conf hook, that unconditionally sets FRAMEBUFFER=y and masks the problem.
I don't have any documentation for FRAMEBUFFER option from initramfs-tools (bug 789141). Changes probably need some review from console-setup and initramfs-tools developers.
| Dimitri John Ledkov (xnox) wrote : | # |
| Colin Watson (cjwatson) wrote : | # |
I'd like to have some time to review this before it lands, as this is a very delicate area. I'll try to make time for it next week.
| Oliver Grawert (ogra) wrote : | # |
i dont think it is the right approach to forcefully set FRAMEBUFFER=y as soon as splash is set on the commandline, imho the setting of the font should not depend on the type of output ...
also note that FRAMEBUFFER=y installs additional plymouth theme bits in the initrd growing its size by quite a bit.
the better option would be to simply not depend on FRAMEBUFFER for the console-setup hook (if thats doable without breakage) and install it regardless
| Andrey Bondarenko (abone) wrote : | # |
I agree that it is better if setting up font does not depend on FRAMEBUFFER, but don't know if OPTION may be safely removed. My knowledge of linux console is rather weak. Will try to test.
| Andrey Bondarenko (abone) wrote : | # |
I've tried to remove OPTION=FRAMEBUFFER from init-top/
So, I don't mind having console_setup enabled all the time. Another way, if you prefer to save some space in latin locales, is to creaate separate option for console-setup, and enable it regardles of framebuffer usage. For example it can be enabled if /etc/default/locale contains some non-latin locale or /etc/default/
My patch also contains upstart job for console-setup. This job, in my opinion, should be enabled anyway.
Waiting for your feedback.
| Colin Watson (cjwatson) wrote : | # |
After some thought, I agree that this Upstart job is the right thing to add, and I'm going to apply this to quantal. Thanks!
I am much less convinced by the proposal to remove OPTION=FRAMEBUFFER (and still less by the proposal to force FRAMEBUFFER=y when splash is enabled; I agree with Oliver on that). I also don't think that creating a separate option for it is the right answer. If the framebuffer isn't enabled for some other reason, then the console-setup script should not need to run in the initramfs at all (except in the case of a panic, which is handled); the fact that this shouldn't be needed is what OPTION=FRAMEBUFFER expresses. It should be sufficient for the corresponding code to run from udev rules and Upstart jobs.
Therefore, if the udev rules and Upstart jobs aren't working properly when there is no framebuffer code in the initramfs, that is what needs to be debugged. I believe this ought to be possible without running console-setup code in the initramfs.
| Colin Watson (cjwatson) wrote : | # |
I have merged the Upstart job part of this into lp:~ubuntu-core-dev/console-setup/ubuntu, which is the development branch we use. For future console-setup work, please branch from and propose to there.
I think it's least confusing (although no option avoids confusion altogether) if I mark this merge proposal as merged at this point, and suggest that you file something separately with whatever arises from my comments about OPTION=FRAMEBUFFER. These seem to be separate issues to some extent, so let's treat them separately.
| Andrey Bondarenko (abone) wrote : | # |
Ok, I've tested console-setup version 1.70ubuntu6. I think it will solve the bug 433897 for most users. There is some small issue with mount all and fsck on boot (both print translated messages while font it configured), but I think most people can live with it.
Thank you.
looks good. There is a typo in the comment 'If /etc/default/grub has "spalsh" option in' s/spalsh/splash/.
Will test and merge if this fixes the problems.