Merge lp:~abompard/mailman/mailman-templates-utf8 into lp:mailman
Proposed by
Aurélien Bompard
Status: | Merged |
---|---|
Merge reported by: | Barry Warsaw |
Merged at revision: | not available |
Proposed branch: | lp:~abompard/mailman/mailman-templates-utf8 |
Merge into: | lp:mailman |
Diff against target: |
45 lines (+16/-1) 2 files modified
src/mailman/utilities/i18n.py (+1/-1) src/mailman/utilities/tests/test_templates.py (+15/-0) |
To merge this branch: | bzr merge lp:~abompard/mailman/mailman-templates-utf8 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw | Approve | ||
Review via email: mp+249358@code.launchpad.net |
Description of the change
As discussed on the mailing-list in October, the templates should be encoded in UTF-8.
(https:/
However, the current code does not specify this and relies on locale.
You can verify this by running the test suite with LANG=C.
This branch forces the templates encoding to UTF-8 on read().
To post a comment you must log in.
Chatting about this at Pycon 2015, we decided to apply the patch, which seems reasonable on the face of it. I won't apply the test; eventually CI should probably run them under different locales, or we should use some subunit or other subprocess runner.