Code review comment for lp:~abompard/mailman/fix-import-from-mm2
Revision history for this message
| Aurélien Bompard (abompard) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Thanks a lot for this merge. I'll try to keep your changes in mind for future MP (single quotes are preferred, describe tests with comments, etc.)
I don't quite understand your concern about the Bouncer class. It's there to allow loading the pickles when they include instances of a Bouncer._BounceInfo class (where Bouncer is the name of a module in MM2.1). I don't do anything with it, but the unpickling will fail without it (with real data from the Fedora lists).