Merge lp:~abompard/mailman/failing-test into lp:mailman
Proposed by
Aurélien Bompard
Status: | Merged |
---|---|
Approved by: | Barry Warsaw |
Approved revision: | 7265 |
Merged at revision: | 7265 |
Proposed branch: | lp:~abompard/mailman/failing-test |
Merge into: | lp:mailman |
Diff against target: |
42 lines (+13/-8) 1 file modified
src/mailman/database/tests/test_factory.py (+13/-8) |
To merge this branch: | bzr merge lp:~abompard/mailman/failing-test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw | Approve | ||
Review via email: mp+243033@code.launchpad.net |
Description of the change
Fix a failing schemamanager test
To post a comment you must log in.
Thanks! I made a few small changes.
* in TestSchemaManag er.setUp( ), I used md.sorted_tables so I didn't have to call .values():
for table in md.sorted_tables:
table. drop(config. db.engine)
* In test_initial() I used assertIn() on md.tables (since if it's a mapping, `in` should automatically compare against .keys()):
I don't quite understand the code though, and I would like to add some comments to the test.
* After calling setup_database(), why would you expect that alembic. command. upgrade was not called?
* After calling setup_database(), would you expect alembic_version table to exist, or would it only exist after the md.reflect() call?