Merge lp:~abogani/ubuntu/lucid/avrdude/avrdude.fix-529444 into lp:ubuntu/lucid/avrdude

Proposed by Alessio Igor Bogani on 2010-03-18
Status: Merged
Merged at revision: not available
Proposed branch: lp:~abogani/ubuntu/lucid/avrdude/avrdude.fix-529444
Merge into: lp:ubuntu/lucid/avrdude
Diff against target: 54 lines (+17/-5)
3 files modified
debian/changelog (+11/-0)
debian/control (+2/-1)
ser_posix.c (+4/-4)
To merge this branch: bzr merge lp:~abogani/ubuntu/lucid/avrdude/avrdude.fix-529444
Reviewer Review Type Date Requested Status
James Westby (community) 2010-03-18 Approve on 2010-03-23
Ubuntu Sponsors Team 2010-03-18 Pending
Review via email: mp+21640@code.launchpad.net

Description of the Change

Test build available in my PPA:
https://launchpad.net/~abogani/+archive/broken

Fix is backported from upstream development version. It also affect only code relevant for feature that fix (so low probability of regression).

User report that it really fix the bug:
https://bugs.launchpad.net/arduino/+bug/529444/comments/16

To post a comment you must log in.
Alessio Igor Bogani (abogani) wrote :

Now all bug affected users confirm that fix works:
https://bugs.launchpad.net/arduino/+bug/529444/comments/19

James Westby (james-w) wrote :

Uploaded, thanks.

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-01-19 18:57:14 +0000
3+++ debian/changelog 2010-03-18 14:06:21 +0000
4@@ -1,3 +1,14 @@
5+avrdude (5.10-1ubuntu1) lucid; urgency=low
6+
7+ * Backport of fix for arduino programmer type
8+ Source code changes have been backported from development version in svn
9+ tree http://svn.savannah.gnu.org/viewvc?view=rev&root=avrdude&revision=940
10+ These changes are related to Arduino's auto-reset after programming feature
11+ fixed with this patch in ser_posix.c file.
12+ - LP: #529444
13+
14+ -- Alessio Igor Bogani <abogani@ubuntu.com> Tue, 16 Mar 2010 22:42:23 +0100
15+
16 avrdude (5.10-1) unstable; urgency=low
17
18 * New upstream release.
19
20=== modified file 'debian/control'
21--- debian/control 2009-09-23 15:10:47 +0000
22+++ debian/control 2010-03-18 14:06:21 +0000
23@@ -1,7 +1,8 @@
24 Source: avrdude
25 Section: electronics
26 Priority: extra
27-Maintainer: Michael Biebl <biebl@debian.org>
28+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29+XSBC-Original-Maintainer: Michael Biebl <biebl@debian.org>
30 Build-Depends: cdbs,
31 debhelper (>= 7),
32 autotools-dev,
33
34=== modified file 'ser_posix.c'
35--- ser_posix.c 2010-01-17 14:19:31 +0000
36+++ ser_posix.c 2010-03-18 14:06:21 +0000
37@@ -230,13 +230,13 @@
38 }
39
40 if (is_on) {
41+ /* Set DTR and RTS */
42+ ctl |= (TIOCM_DTR | TIOCM_RTS);
43+ }
44+ else {
45 /* Clear DTR and RTS */
46 ctl &= ~(TIOCM_DTR | TIOCM_RTS);
47 }
48- else {
49- /* Set DTR and RTS */
50- ctl |= (TIOCM_DTR | TIOCM_RTS);
51- }
52
53 r = ioctl(fdp->ifd, TIOCMSET, &ctl);
54 if (r < 0) {

Subscribers

People subscribed via source and target branches