Merge lp:~abhishekkumarsingh-cse/ubuntu/oneiric/base-files/oneiric into lp:ubuntu/oneiric/base-files

[Abhishek kumar singh]

[lp:~abhishekkumarsingh-cse/ubuntu/oneiric/base-files/oneiric]

83. By Abhishek kumar singh on 2011-10-27

Bash scripting bug fixed(LP: #683311).

[Stéphane Graber (stgraber)]

That changelog doesn't contain a valid e-mail address. You probably also want a space between the comment and the (LP...).

You also need to either target the current development release, "precise" if the fix isn't in there already or if it's, then target "oneiric-proposed" with version number 6.4ubuntu5.1.

Marking the branch as work in progress, please switch it back to needs review once the changes are done.

Thanks!

[Colin Watson (cjwatson)]

Also maybe a better changelog entry; this is a quoting bug, and isn't bash-specific. As a general rule of thumb, I find it best to describe the functional change being made rather than describing the bug being fixed.

Unmerged revisions

83. By Abhishek kumar singh on 2011-10-27

Bash scripting bug fixed(LP: #683311).

=== modified file 'debian/changelog'
--- debian/changelog	2011-10-08 00:45:55 +0000
+++ debian/changelog	2011-10-27 18:25:26 +0000
@@ -1,3 +1,9 @@
+base-files (6.4ubuntu6) oneiric; urgency=low
+
+  * Bash scripting bug fixed(LP: #683311).
+
+ -- ABHISHEK SINGH <abhishek@abhishek-VirtualBox>  Fri, 28 Oct 2011 05:01:10 +0530
+
 base-files (6.4ubuntu5) oneiric; urgency=low
 
   * /etc/issue, /etc/issue.net, /etc/lsb-release: Prepare for Oneiric

=== modified file 'share/profile'
--- share/profile	2011-06-22 08:24:53 +0000
+++ share/profile	2011-10-27 18:25:26 +0000
@@ -3,8 +3,8 @@
 
 if [ -d /etc/profile.d ]; then
   for i in /etc/profile.d/*.sh; do
-    if [ -r $i ]; then
-      . $i
+    if [ -r "$i" ]; then
+      . "$i"
     fi
   done
   unset i