Merge lp:~abhiram-ampabathina/gtg/gtg2 into lp:~gtg/gtg/old-trunk

Proposed by Abhiram on 2012-08-16
Status: Rejected
Rejected by: Izidor Matušov on 2013-02-11
Proposed branch: lp:~abhiram-ampabathina/gtg/gtg2
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 78 lines (+14/-8)
3 files modified
GTG/gtk/browser/__init__.py (+2/-2)
GTG/gtk/browser/browser.py (+10/-4)
GTG/gtk/editor/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~abhiram-ampabathina/gtg/gtg2
Reviewer Review Type Date Requested Status
Izidor Matušov 2012-08-16 Disapprove on 2013-02-11
Bertrand Rousseau (community) code, run 2012-11-07 Needs Fixing on 2012-11-10
Review via email: mp+119941@code.launchpad.net

Description of the change

Hello,
      This is the merge request for the bug "Mouseover string incorrect". All the desired changes have been made for the tooltip design. Now it is made appropriate that the tooltip reacts with the status of the current task selected or not selected. Please, have a look and review it, it is working fine with me.

Best

To post a comment you must log in.
Izidor Matušov (izidor) wrote :

Get rid of the print statement. Otherwise it looks good.

review: Needs Fixing (code, running)
lp:~abhiram-ampabathina/gtg/gtg2 updated on 2012-08-16
1240. By Abhiram on 2012-08-16

removed the print statement

Abhiram (abhiram-ampabathina) wrote :

Hi izidor,
          Removed the print statement. Just wrote it for tracing purposes. Forgot to remove it. Removed it now.

Best,
Abhiram

Abhiram (abhiram-ampabathina) wrote :

Hello izidor,
        I guess i removed the print statement. If there is any problem in other parts of the code, let me know.

Best,
Abhiram

This one is deferred to 0.3.1 since we're now focusing on 0.3 release. Feel free to remind us to review this merge request after 0.3 is released if we take too much time to get back to it.

The patch is pretty much ok, except for one thing: I think the the new tooltip text for UNDISMISS is not correct. The original text ("Mark this task as to be done") was correct (although not very clear I admit, but fixing it requires to discuss the task activation/deactivation flow a bit)

Also, please update your patch by merging the trunk in it, and update the CHANGELOG to record your fix.

review: Needs Fixing (code, run)
Izidor Matušov (izidor) wrote :

Rejecting this patch for inactivty and not fixing problems.

review: Disapprove

Unmerged revisions

1240. By Abhiram on 2012-08-16

removed the print statement

1239. By Abhiram on 2012-08-16

made complete changes to tooltips. Makes better sense now.

1238. By Abhiram on 2012-08-08

fix for bug Mouseover string incorrrect

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GTG/gtk/browser/__init__.py'
2--- GTG/gtk/browser/__init__.py 2012-08-08 14:56:18 +0000
3+++ GTG/gtk/browser/__init__.py 2012-08-16 16:31:22 +0000
4@@ -36,11 +36,11 @@
5 MARK_DONE = _("Mark as Done")
6 MARK_DONE_TOOLTIP = _("Mark the selected task as done")
7 MARK_UNDONE = _("Mark as not Done")
8- MARK_UNDONE_TOOLTIP = _("Mark the selected task as to be done")
9+ MARK_UNDONE_TOOLTIP = _("Mark the selected task as not done")
10 MARK_DISMISS = _("Dismiss")
11 MARK_DISMISS_TOOLTIP = _("Mark the task as not to be done anymore")
12 MARK_UNDISMISS = _("Undismiss")
13- MARK_UNDISMISS_TOOLTIP = _("Mark the selected task as to be done")
14+ MARK_UNDISMISS_TOOLTIP = _("Mark the selected task as not done")
15 DELETE_TOOLTIP = _("Permanently remove the selected task")
16 EDIT_TOOLTIP = _("Edit the selected task")
17 NEW_TASK_TOOLTIP = _("Create a new task")
18
19=== modified file 'GTG/gtk/browser/browser.py'
20--- GTG/gtk/browser/browser.py 2012-08-12 23:01:10 +0000
21+++ GTG/gtk/browser/browser.py 2012-08-16 16:31:22 +0000
22@@ -221,9 +221,7 @@
23 """
24 sets tooltips for widgets on toolbars
25 """
26- self.donebutton.set_tooltip_text(GnomeConfig.MARK_DONE_TOOLTIP)
27 self.editbutton.set_tooltip_text(GnomeConfig.EDIT_TOOLTIP)
28- self.dismissbutton.set_tooltip_text(GnomeConfig.MARK_DISMISS_TOOLTIP)
29 self.newtask.set_tooltip_text(GnomeConfig.NEW_TASK_TOOLTIP)
30 self.newsubtask.set_tooltip_text(GnomeConfig.NEW_SUBTASK_TOOLTIP)
31 self.toggle_workview.set_tooltip_text(
32@@ -1162,7 +1160,10 @@
33 def update_button(button, settings):
34 button.set_icon_name(settings["icon-name"])
35 button.set_label(settings["label"])
36-
37+ button.set_tooltip_text(settings["tooltip"])
38+ if selection.count_selected_rows() == 0:
39+ button.set_tooltip_text("")
40+
41 def update_menu_item(menu_item, settings):
42 image = gtk.image_new_from_icon_name(settings["icon-name"], 16)
43 image.set_pixel_size(16)
44@@ -1205,12 +1206,17 @@
45 #Only if something is selected in the active task list
46 self.donebutton.set_icon_name("gtg-task-done")
47 self.dismissbutton.set_icon_name("gtg-task-dismiss")
48+ if selection.count_selected_rows() == 0 :
49+ self.donebutton.set_tooltip_text("")
50+ self.dismissbutton.set_tooltip_text("")
51+
52 if selection.count_selected_rows() > 0:
53 if 'closed' in self.vtree_panes:
54 self.vtree_panes['closed'].get_selection().unselect_all()
55 self.donebutton.set_label(GnomeConfig.MARK_DONE)
56 self.donebutton.set_tooltip_text(GnomeConfig.MARK_DONE_TOOLTIP)
57- self.dismissbutton.set_label(GnomeConfig.MARK_DISMISS)
58+ self.dismissbutton.set_tooltip_text(GnomeConfig.MARK_DISMISS_TOOLTIP)
59+ self.dismissbutton.set_label(GnomeConfig.MARK_DISMISS)
60 self.update_buttons_sensitivity()
61
62 def on_close(self, widget=None):
63
64=== modified file 'GTG/gtk/editor/__init__.py'
65--- GTG/gtk/editor/__init__.py 2012-05-23 08:55:31 +0000
66+++ GTG/gtk/editor/__init__.py 2012-08-16 16:31:22 +0000
67@@ -34,9 +34,9 @@
68 MARK_UNDISMISS = _("Undismiss")
69
70 MARK_DONE_TOOLTIP = _("Mark this task as done")
71- MARK_UNDONE_TOOLTIP = _("Mark this task as to be done")
72+ MARK_UNDONE_TOOLTIP = _("Mark this task as not done")
73 MARK_DISMISS_TOOLTIP = _("Mark this task as not to be done anymore")
74- MARK_UNDISMISS_TOOLTIP = _("Mark this task as to be done")
75+ MARK_UNDISMISS_TOOLTIP = _("Mark this task as not done")
76 DELETE_TOOLTIP = _("Permanently remove this task")
77 SUBTASK_TOOLTIP = _("Insert a subtask in this task")
78 TAG_TOOLTIP = _("Insert a tag in this task")

Subscribers

People subscribed via source and target branches

to status/vote changes: